samba.git/source3/libsmb, branch talloc-2.3.4

s3:libsmb: Covscan: unchecked return value for cli_credentials_set_smb_encryption()

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

s3: libsmbclient: Cope with SMB2 servers that return STATUS_USER_SESSION_DELETED on a SMB2_ECHO (SMB2_OP_KEEPALIVE) call with a NULL session.

2022-05-11T18:06:42+00:00

This is already tested by smb2.session.expire which
shows that Windows and Samba servers don't need this,
but some third party server are returning STATUS_USER_SESSION_DELETED
with a NULL sessionid.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13218

Signed-off-by: Jeremy Allison 
Reviewed-by: Bjoern Jacke 

Autobuild-User(master): Björn Jacke 
Autobuild-Date(master): Wed May 11 18:06:42 UTC 2022 on sn-devel-184

lib: Remove smb_threads from includes.h

2022-04-26T21:41:29+00:00

Only used in libsmb_context.c

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3:libsmb: Fix errno for failed authentication in SMBC_server_internal()

2022-03-16T19:44:18+00:00

In SMBC_server_internal(), when authentication fails, the errno value is
currently hard-coded to EPERM, while it should be EACCES instead. Use the
NT_STATUS map to set the appropriate value.

This bug was found because it breaks listing printers protected by
authentication in GNOME Control Panel.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14983

Signed-off-by: Elia Geretto 
Reviewed-by: Jeremy Allison 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Mar 16 19:44:18 UTC 2022 on sn-devel-184

s3:trusts_utils: use a password length of 120 for machine accounts

2022-02-23T08:49:54+00:00

This is important when we change the machine password against
an RODC that proxies the request to an RWDC.

An RODC using NetrServerPasswordSet2() to proxy PasswordUpdateForward via
NetrLogonSendToSam() ignores a return of NT_STATUS_INVALID_PARAMETER
and reports NT_STATUS_OK as result of NetrServerPasswordSet2().
This hopefully found the last hole in our very robust machine account
password handling logic inside of trust_pw_change().

The lesson is: try to be as identical to how windows works as possible,
everything else may use is untested code paths on Windows.

A similar problem was fixed by this commit:

    commit 609ca657652862fd9c81fd11f818efb74f72ff55
    Author: Joseph Sutton 
    Date:   Wed Feb 24 02:03:25 2021 +1300

        provision: Decrease the length of random machine passwords

        The current length of 128-255 UTF-16 characters currently causes
        generation of crypt() passwords to typically fail. This commit
        decreases the length to 120 UTF-16 characters, which is the same as
        that used by Windows.

        BUG: https://bugzilla.samba.org/show_bug.cgi?id=14621

        Signed-off-by: Joseph Sutton 
        Reviewed-by: Douglas Bagnall 
        Reviewed-by: Andrew Bartlett 

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14984

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Wed Feb 23 08:49:54 UTC 2022 on sn-devel-184

libsmb: Avoid a call to SMBC_errno()

2022-02-17T17:13:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libsmb: Avoid a call to SMBC_errno()

2022-02-17T17:13:34+00:00

This involves converting cli_print_queue() to NTSTATUS. No caller
looked at the number of jobs returned.

Review with "git show -b", most of the patch is indentation

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libsmb: Use fstrcpy where possible

2022-02-11T20:54:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libsmb: Convert SMBC_getatr() to NTSTATUS

2022-02-07T19:00:34+00:00

This avoids a few calls to SMBC_errno()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

libsmb: Avoid a call to SMBC_errno()

2022-02-07T19:00:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison