samba.git/source3/locking/brlock.c, branch master

s3/brlock: map nt-error from correct errno-value

2026-04-21T02:05:57+00:00

The functions 'brl_lock_windows_default' and 'brl_lock_posix' uses
explicit 'errno_ret' value to avoid possible errno overwrite. Use in
failure case.

Signed-off-by: Shachar Sharon 
Reviewed-by: Anoop C S 
Reviewed-by: Shwetha Acharya 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Tue Apr 21 02:05:57 UTC 2026 on atb-devel-224

s3:locking: make leases.tdb none readable for others

2026-04-07T15:09:38+00:00

Signed-off-by: Ralph Wuerthner 
Reviewed-by: Xavi Hernandez 
Reviewed-by: Martin Schwenke 
Reviewed-by: Anoop C S

smbd: move lp_locking() check inside file_has_brlocks()

2025-10-10T15:59:35+00:00

Avoids doing the check at every caller.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

s3/locking: fix checking for byterange locks when granting RH lease

2025-08-15T15:46:35+00:00

From MS-FSA 2.1.5.18 "Server Requests an Oplock":

...

* Else If Type is LEVEL_GRANULAR:
    * If RequestedOplockLevel is READ_CACHING or (READ_CACHING|HANDLE_CACHING):
        * The operation MUST be failed with STATUS_OPLOCK_NOT_GRANTED under either of the
          following conditions:
            * Open.Stream.ByteRangeLockList is not empty and Open.Stream.AllocationSize
              is greater than any ByteRangeLock.LockOffset in
              Open.Stream.ByteRangeLockList.

...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15894

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

s3/locking: modernize file_has_brlocks()

2025-08-15T15:46:35+00:00

No change in behaviour. Minimizes diff in the next commit that introduce a
behaviour change.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15894

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

smbd: make file_has_brlocks() public

2025-08-15T15:46:35+00:00

Prepares for a change to file_has_brlocks() in the next commit. No change in
behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15894

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

smbd: use share_mode_do_locked_brl() in vfs_default_durable_reconnect()

2025-04-02T18:05:48+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15767

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

smbd: use share_mode_do_locked_brl() in vfs_default_durable_disconnect()

2025-04-02T18:05:48+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15767

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

s3/locking: prepare brl_locktest() for upgradable read-only locks

2025-04-02T18:05:48+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15767

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

s3/brlock: remove brl_get_locks_for_locking()

2025-04-02T18:05:48+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15767

Pair-Programmed-With: Ralph Boehme 
Signed-off-by: Ralph Boehme 
Signed-off-by: Stefan Metzmacher