samba.git/source3/locking/locking.c, branch talloc-2.3.4

s3: smbd: Move implicit call to lp_posix_cifsu_locktype() out of init_strict_lock_struct().

2022-01-06T15:11:38+00:00

Make it explicit. When we add POSIX handles to SMB2 we will only
look at the handle type. lp_posix_cifsu_locktype() already does this,
but hidden inside init_strict_lock_struct() makes it hard to see.

No logic change.

Signed-off-by: Jeremy Allison 
Reviewed-by: Noel Power

locking: hide share_mode_lock definition

2020-11-10T21:12:48+00:00

This makes "struct share_mode_lock" an opaque data structure opened up
only to the code in locking/. This makes it much safer to modify the
data structure with defined accessor functions in share_mode_lock.c.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Nov 10 21:12:48 UTC 2020 on sn-devel-184

smbd: Give locking/share_mode_lock.c its own header file

2020-11-10T19:49:34+00:00

To me this is then easier to figure out what is defined there, and
where it's exactly used.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smb: rename NTCREATEX_OPTIONS_PRIVATE_STREAM_BASEOPEN to NTCREATEX_FLAG_STREAM_BASEOPEN

2020-10-23T17:44:34+00:00

Just a shorter name, no change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: increase loglevel when leases_db_del() with anything then NT_STATUS_NOT_FOUND

2020-07-02T15:25:31+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

smbd: Make share_mode_do_locked() use a const uint8_t *

2020-05-05T11:48:40+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

smbd: move files_struct.delete_on_close to a bitfield

2020-04-03T19:05:44+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: move files_struct.is_directory to a bitfield

2020-04-03T19:05:44+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: move files_struct.can_lock to a bitfield

2020-04-03T19:05:43+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: fix handling of sentinel timestamp values

2019-12-06T00:17:36+00:00

This implements two core changes:

* use NTTIME instead of struct timespec at the database layer

* use struct timespec { .tv_nsec = SAMBA_UTIME_OMIT } as special sentinel
  value in smbd when processing timestamps

Using NTTIME at the database layer is only done to avoid storing the special
struct timespec sentinel values on disk. Instead, with NTTIME the sentinel value
for an "unset" timestamp is just 0 on-disk.

The NTTIME value of 0 gets translated by nt_time_to_full_timespec() to the
struct timespec sentinel value { .tv_nsec = SAMBA_UTIME_OMIT }.

The function is_omit_timespec() can be used to check this.

Beside nt_time_to_full_timespec(), there are various other new time conversion
functions with *full* in their name that can be used to safely convert between
different types with the changed sentinel value.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison