samba.git/source3/locking, branch talloc-2.2.0

s3:locking: Add missing NULL check

2019-02-12T22:02:07+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

leases: Streamline leases_db_key a bit

2018-10-03T02:11:59+00:00

We don't need to talloc the blob, it's always the same size

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Oct  3 04:11:59 CEST 2018 on sn-devel-144

smbd: Fix a warning

2018-10-02T23:07:15+00:00

gcc complains that the "const" is ignored on function return
types. Right now I'm compiling this file a lot, so silence this
warning :-)

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbd: Move downgrade_share_lease() to smbd/oplock.c

2018-10-02T16:13:20+00:00

This function is pretty closely entangled with its only caller. In
particular the NT_STATUS_OPLOCK_BREAK_IN_PROGRESS triggers acitivity
in the caller, and that's the only case where "*_l" is being set to
non-NULL. Prepare for cleanup

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

s3/locking: Fix logging of lock reference count

2018-10-02T08:40:05+00:00

lock reference count is always increased and reduced by a value of 1.
But lock_ref_count variable holds the old value prior to change and
was being logged wrongly under debug level 10. DEBUG statement must
log lock_ref_count+1 and lock_ref_count-1 respectively when value
gets increased and decreased.

Signed-off-by: Anoop C S 
Reviewed-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3/locking: Fix comments to reflect code flow

2018-09-19T20:23:28+00:00

* posix_pending_close_db is an in-memory database and not a tdb.
  Therefore adjusting comments to convey the correct meaning of the
  database.
* we do not have posix_locking_close_file() any more which got renamed
  to locking_close_file(). Thus fixing comment to mention the new name.

Signed-off-by: Anoop C S 
Reviewed-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Sep 19 22:23:28 CEST 2018 on sn-devel-144

smbd: Simplify parse_share_modes

2018-09-14T05:49:14+00:00

Since 823bc4c07ad pidl initializes the [skip] entries

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

smbd: Simplify share_mode_lock.c

2018-09-14T05:49:14+00:00

"the_lock_id" is not required here. The share mode data carry the file
id, so use that.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

smbd: Fix a false comment

2018-09-14T05:49:13+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

smbd: Avoid casts in DEBUG statements

2018-09-14T05:49:13+00:00

Some indentation changed, best viewed with "git show -w"

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme