samba.git/source3/locking, branch talloc-2.3.2

smb: rename NTCREATEX_OPTIONS_PRIVATE_STREAM_BASEOPEN to NTCREATEX_FLAG_STREAM_BASEOPEN

2020-10-23T17:44:34+00:00

Just a shorter name, no change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

s3:share_mode_lock: remove unused reproducer for bug #14428

2020-08-31T13:34:17+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Mon Aug 31 13:34:17 UTC 2020 on sn-devel-184

s3:share_mode_lock: make sure share_mode_cleanup_disconnected() removes the record

2020-08-31T11:57:01+00:00

This fixes one possible trigger for "PANIC: assert failed in get_lease_type()"
https://bugzilla.samba.org/show_bug.cgi?id=14428

This is no longer enough to remove the record:

   d->have_share_modes = false;
   d->modified = true;

Note that we can remove it completely from
share_mode_cleanup_disconnected() as
share_mode_forall_entries() already sets it
when there are no entries left.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

s3:share_mode_lock: add missing 'goto done' in share_mode_cleanup_disconnected()

2020-08-31T11:57:01+00:00

When cleanup_disconnected_lease() fails we should stop,
at least we do that if brl_cleanup_disconnected() fails.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

s3:share_mode_lock: consistently debug share_mode_entry records

2020-08-31T11:57:01+00:00

share_mode_entry_do(), share_mode_forall_entries() and
share_entry_forall() print the record before the callback is called
and when it was modified or deleted.

This makes it much easier to debug problems.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

s3:share_mode_lock: let share_mode_forall_entries/share_entry_forall evaluate e.stale first

2020-08-31T11:57:01+00:00

It's not really clear why e.stale would be ignored if *modified is set
to true.

This matches the behavior of share_mode_entry_do()

This also makes sure we see the removed entry in level 10 logs again.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

s3:share_mode_lock: reproduce problem with stale disconnected share mode entries

2020-08-31T11:57:01+00:00

This reproduces the origin of "PANIC: assert failed in get_lease_type()"
(https://bugzilla.samba.org/show_bug.cgi?id=14428).

share_mode_cleanup_disconnected() removes disconnected entries from
leases.tdb and brlock.tdb but not from locking.tdb.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

s3:smbd: avoid dereferencing client->connections

2020-07-08T15:54:40+00:00

There're typically better ways to get the same information.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner

s3:locking: convert share_mode_lock.c to generate_unique_u64()

2020-07-08T09:42:40+00:00

Instead of a sequence number that gets incremented we just
need a value that's not reused.

The is a similar change like the commit before at the g_lock.c
layer.

I expect a similar performance improvement here, but
I don't know a specific benchmark test to check.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

s3:leases: log errors with level 0 in leases_db_do_locked_fn()

2020-07-07T01:25:49+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison