samba.git/source3/locking, branch talloc-2.3.3

smbd: Simplify share_mode_entry_do()

2021-06-04T16:47:34+00:00

Looking at the logic of "ha[d|ve]_share_mode_entry" d->modified=true
can only happen if we remove the last share mode entry . Make this
more explicit, avoid booleans.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbd: Make share_mode_lock.h includable on its own

2021-05-11T22:56:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

locking: Fix an uninitialized variable read

2021-03-05T10:18:07+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14636
Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

share_mode_lock: DEBUG/ASSERT recursion deadlock detection

2021-01-21T13:35:33+00:00

This situation should never happen!

The known trigger is fixed with the change to adouble_open_rsrc_fsp()

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib: give global_contexts.c its own header file

2021-01-08T20:31:33+00:00

It's a bit shocking how many references we have to global
contexts. Make this a bit more obvious.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fh_[get|set]_private_options()

2020-12-16T09:08:30+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fh_[get|set]_gen_id()

2020-12-16T09:08:30+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fsp_get_pathref_fd() when close()ing fds

2020-12-16T09:08:30+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fsp_get_pathref_fd() as part of DEBUG and syslog messages

2020-12-16T09:08:30+00:00

Nothing really dangerous is done with the fds here, so we can safely use
fsp_get_pathref_fd() in these cases.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fsp_get_io_fd() when accessing a file or it's associated metadata

2020-12-16T09:08:30+00:00

In all places where we access or modify a file or it's associated metadata, we
use fsp_get_io_fd() to fetch the low-level fd from the fsp. This ensures we
don't accidentally use a pathref fsp where the fd would be opened as root on
systems lacking O_PATH.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison