samba.git/source3/locking, branch talloc-2.3.4

s3: smbd: Move implicit call to lp_posix_cifsu_locktype() out of init_strict_lock_struct().

2022-01-06T15:11:38+00:00

Make it explicit. When we add POSIX handles to SMB2 we will only
look at the handle type. lp_posix_cifsu_locktype() already does this,
but hidden inside init_strict_lock_struct() makes it hard to see.

No logic change.

Signed-off-by: Jeremy Allison 
Reviewed-by: Noel Power

smbd: Simplify mark_share_mode_disconnected()

2021-08-06T18:09:06+00:00

We can use reset_share_mode_entry() for this purpose. 32 lines less
code.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug  6 18:09:06 UTC 2021 on sn-devel-184

smbd: Fix fetch_share_mode_send() error return

2021-08-06T17:22:30+00:00

The "return" is unnecessary here, but in case the code changes later
on, it won't be forgotten. Also, we need to tell the callers that we
found an invalid record.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbd: Simplify share_mode_entry_do()

2021-06-04T16:47:34+00:00

Looking at the logic of "ha[d|ve]_share_mode_entry" d->modified=true
can only happen if we remove the last share mode entry . Make this
more explicit, avoid booleans.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbd: Make share_mode_lock.h includable on its own

2021-05-11T22:56:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

locking: Fix an uninitialized variable read

2021-03-05T10:18:07+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14636
Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

share_mode_lock: DEBUG/ASSERT recursion deadlock detection

2021-01-21T13:35:33+00:00

This situation should never happen!

The known trigger is fixed with the change to adouble_open_rsrc_fsp()

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib: give global_contexts.c its own header file

2021-01-08T20:31:33+00:00

It's a bit shocking how many references we have to global
contexts. Make this a bit more obvious.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fh_[get|set]_private_options()

2020-12-16T09:08:30+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fh_[get|set]_gen_id()

2020-12-16T09:08:30+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison