samba.git/source3/locking, branch talloc-2.4.4

s3/locking: fix checking for byterange locks when granting RH lease

2025-08-15T15:46:35+00:00

From MS-FSA 2.1.5.18 "Server Requests an Oplock":

...

* Else If Type is LEVEL_GRANULAR:
    * If RequestedOplockLevel is READ_CACHING or (READ_CACHING|HANDLE_CACHING):
        * The operation MUST be failed with STATUS_OPLOCK_NOT_GRANTED under either of the
          following conditions:
            * Open.Stream.ByteRangeLockList is not empty and Open.Stream.AllocationSize
              is greater than any ByteRangeLock.LockOffset in
              Open.Stream.ByteRangeLockList.

...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15894

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

s3/locking: modernize file_has_brlocks()

2025-08-15T15:46:35+00:00

No change in behaviour. Minimizes diff in the next commit that introduce a
behaviour change.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15894

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

smbd: make file_has_brlocks() public

2025-08-15T15:46:35+00:00

Prepares for a change to file_has_brlocks() in the next commit. No change in
behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15894

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

smbd: Fix whitespace

2025-06-14T08:46:33+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

smbd: convert all fsp->fh->private_options to fsp_flags

2025-04-09T14:39:26+00:00

Use fsp_apply_private_ntcreatex_flags() to store the private_flags as fsp_flags
and convert all users to check the fsp_flags.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Wed Apr  9 14:39:26 UTC 2025 on atb-devel-224

s3/locking: remove now unused private_options from share_mode_entry

2025-04-09T13:40:36+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

s3/locking: store NTCREATEX_FLAG_DENY_[DOS|FCB] as share_entry_flags

2025-04-09T13:40:36+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

s3/locking: store NTCREATEX_FLAG_STREAM_BASEOPEN as share_entry_flag

2025-04-09T13:40:36+00:00

No change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

s3/locking: add and use fsp_[get|apply]_share_entry_flags()

2025-04-09T13:40:36+00:00

Prepares for converting private_options to flags.

Fixes Durable Handle reconnect of POSIX opens which weren't setting the fsp_flags
when reconnecting, so fsp_flags.posix_open wasn't set.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

smbd: rename SHARE_MODE_FLAG_POSIX_OPEN to SHARE_ENTRY_FLAG_POSIX_OPEN

2025-04-09T13:40:36+00:00

share_mode_data has flags and share_mode_entry has flags, this change allows
to distinguish between both more easily. No change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke