samba.git/source3/modules/vfs_commit.c, branch master

vfs_commit: Do initial eof calculation on demand

2026-01-07T09:57:41+00:00

Avoid yet another fstat call at open time, we might never write to the
file

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

vfs_commit: Some README.Coding changes

2026-01-07T09:57:41+00:00

Reduce indentation with early returns

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

vfs_commit: Reduce indentation with early returns

2026-01-07T09:57:41+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

vfs_commit: Make dbytes and dthresh size_t

2026-01-07T09:57:41+00:00

Those can never go negative, use "%zu" as printf modifier

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

s3:modules: Fix code spelling

2023-07-17T11:46:29+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

vfs: change openat propotype to match linux openat2

2022-08-06T01:43:50+00:00

The Linux prototype for openat2 looks like this:

       long openat2(int dirfd, const char *pathname,
                   struct open_how *how, size_t size);

where "struct open_how" is defined in "linux/openat2.h". It is
designed to be extensible with further flags.

The "size" parameter is required because there is no type checking
between userland and kernelspace, so the way for Linux to find which
version of open_how is being passed in is looking at the size:
"open_how" is expected to only every grow with additional fields,
should a change be necessary in the future.

Samba does not have this problem, we can typecheck the struct and
pointers, we expect all VFS modules to be compiled against the current
vfs.h.

For now this adds no functionality, but it will make further patches
much smaller.

Pair-programmed-with: Stefan Metzmacher 

Signed-off-by: Volker Lendecke 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

vfs_commit: Reset fsp->fd->fd to -1 after SMB_VFS_CLOSE

2021-12-30T11:03:35+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

smbd: use fh_[get|set]_pos() and fh_[get|set]_position_information()

2020-12-16T09:08:30+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fsp_get_io_fd() when accessing a file or it's associated metadata

2020-12-16T09:08:30+00:00

In all places where we access or modify a file or it's associated metadata, we
use fsp_get_io_fd() to fetch the low-level fd from the fsp. This ensures we
don't accidentally use a pathref fsp where the fd would be opened as root on
systems lacking O_PATH.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: use fsp_set_fd()

2020-12-16T09:08:30+00:00

No change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison