<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/source3/modules/vfs_streams_xattr.c, branch talloc-2.3.0</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>s3:modules: Use hash_inode() in vfs_streams_xattr</title>
<updated>2019-07-03T12:37:11+00:00</updated>
<author>
<name>Andreas Schneider</name>
<email>asn@samba.org</email>
</author>
<published>2019-06-18T15:09:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=9d5044fe97b16158260c504979a1fc808fa901d4'/>
<id>9d5044fe97b16158260c504979a1fc808fa901d4</id>
<content type='text'>
Signed-off-by: Andreas Schneider &lt;asn@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Andreas Schneider &lt;asn@cryptomilk.org&gt;
Autobuild-Date(master): Wed Jul  3 12:37:12 UTC 2019 on sn-devel-184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Andreas Schneider &lt;asn@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Andreas Schneider &lt;asn@cryptomilk.org&gt;
Autobuild-Date(master): Wed Jul  3 12:37:12 UTC 2019 on sn-devel-184
</pre>
</div>
</content>
</entry>
<entry>
<title>s3:vfs: Use GnuTLS MD5 in vfs_streams_xattr</title>
<updated>2019-05-21T00:03:22+00:00</updated>
<author>
<name>Andreas Schneider</name>
<email>asn@samba.org</email>
</author>
<published>2018-11-05T16:41:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=bb273a0053870224862559463c5bf8d76d386e84'/>
<id>bb273a0053870224862559463c5bf8d76d386e84</id>
<content type='text'>
Signed-off-by: Andreas Schneider &lt;asn@samba.org&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Andreas Schneider &lt;asn@samba.org&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3-vfs-streams_xattr: add close call</title>
<updated>2018-12-20T06:18:20+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gd@samba.org</email>
</author>
<published>2018-12-18T16:20:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=1b263ed631c86bf4117c9388fce3fa1f24cea4c9'/>
<id>1b263ed631c86bf4117c9388fce3fa1f24cea4c9</id>
<content type='text'>
https://bugzilla.samba.org/show_bug.cgi?id=13725

We cannot always rely on vfs_default to close the fake fds. This mostly is
relevant when used with another non-local VFS filesystem module such as
gluster.

Guenther

Signed-off-by: Günther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Thu Dec 20 07:18:20 CET 2018 on sn-devel-144
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.samba.org/show_bug.cgi?id=13725

We cannot always rely on vfs_default to close the fake fds. This mostly is
relevant when used with another non-local VFS filesystem module such as
gluster.

Guenther

Signed-off-by: Günther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Thu Dec 20 07:18:20 CET 2018 on sn-devel-144
</pre>
</div>
</content>
</entry>
<entry>
<title>vfs_streams_xattr: fix open implementation</title>
<updated>2018-10-31T20:27:18+00:00</updated>
<author>
<name>Ralph Boehme</name>
<email>slow@samba.org</email>
</author>
<published>2018-08-23T10:07:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=9f58997d7a1ab0358963a45cb8bf291e7afa8068'/>
<id>9f58997d7a1ab0358963a45cb8bf291e7afa8068</id>
<content type='text'>
Since a long time the modules's open function happily returned success
when opening a non existent stream without O_CREAT.

This change fixes it to return -1 and errno=ENOATTR if

o get_ea_value() returns NT_STATUS_NOT_FOUND (eg mapped from
  getxattr() = -1, errno=ENOATTR) and

o flags doesn't contain O_CREAT

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme &lt;slow@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since a long time the modules's open function happily returned success
when opening a non existent stream without O_CREAT.

This change fixes it to return -1 and errno=ENOATTR if

o get_ea_value() returns NT_STATUS_NOT_FOUND (eg mapped from
  getxattr() = -1, errno=ENOATTR) and

o flags doesn't contain O_CREAT

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme &lt;slow@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>streams_xattr: Make error handling more obvious</title>
<updated>2018-09-14T05:49:14+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2018-08-08T12:20:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=aca0f2a18bf39e703a5cf8383ff2089fa0e97221'/>
<id>aca0f2a18bf39e703a5cf8383ff2089fa0e97221</id>
<content type='text'>
Do the NULL check right after the alloc call

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Do the NULL check right after the alloc call

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>streams_xattr: Make error handling more obvious</title>
<updated>2018-09-14T05:49:14+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2018-08-08T12:20:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=36055dbb660a1a1086e06b3849e4deb93f2a99ef'/>
<id>36055dbb660a1a1086e06b3849e4deb93f2a99ef</id>
<content type='text'>
Do the NULL check right after the alloc call

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Do the NULL check right after the alloc call

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: VFS: Remove SMB_VFS_FCHMOD_ACL().</title>
<updated>2018-05-25T16:39:25+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2018-05-17T18:48:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=5bbb8310417563b17d83bb9ea9d08940d26e90e1'/>
<id>5bbb8310417563b17d83bb9ea9d08940d26e90e1</id>
<content type='text'>
No longer used.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
No longer used.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: VFS: Remove fsync_fn() from the VFS and all modules. VFS ABI change.</title>
<updated>2018-05-01T23:06:27+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2018-04-28T00:06:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=bc71cd035c816de4ca98002860496bf8f5d50fe3'/>
<id>bc71cd035c816de4ca98002860496bf8f5d50fe3</id>
<content type='text'>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Ralph Böhme &lt;slow@samba.org&gt;
Autobuild-Date(master): Wed May  2 01:06:28 CEST 2018 on sn-devel-144
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Ralph Böhme &lt;slow@samba.org&gt;
Autobuild-Date(master): Wed May  2 01:06:28 CEST 2018 on sn-devel-144
</pre>
</div>
</content>
</entry>
<entry>
<title>s3: vfs: vfs_streams_xattr: Don't blindly re-use the base file mode bits.</title>
<updated>2018-04-11T21:09:12+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2018-04-11T15:41:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=4d839d0f46b723ed6809bb932b9ebe4ead2cec82'/>
<id>4d839d0f46b723ed6809bb932b9ebe4ead2cec82</id>
<content type='text'>
When returning the stat struct for an xattr stream,
we originally base the st_ex_mode field on the value
from the base file containing the xattr. If the base
file is a directory, it will have S_IFDIR set in st_ex_mode,
but streams can never be directories, they must be reported
as regular files.

The original code OR'ed in S_IFREG, but neglected to
AND out S_IFDIR.

Note this is not a complete to fix bug 13380 as
it doesn't fix the generic case with all streams
modules. See later fix and regression test.

Found in real-world use case by Andrew Walker &lt;awalker@ixsystems.com&gt;.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Böhme &lt;slow@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When returning the stat struct for an xattr stream,
we originally base the st_ex_mode field on the value
from the base file containing the xattr. If the base
file is a directory, it will have S_IFDIR set in st_ex_mode,
but streams can never be directories, they must be reported
as regular files.

The original code OR'ed in S_IFREG, but neglected to
AND out S_IFDIR.

Note this is not a complete to fix bug 13380 as
it doesn't fix the generic case with all streams
modules. See later fix and regression test.

Found in real-world use case by Andrew Walker &lt;awalker@ixsystems.com&gt;.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Böhme &lt;slow@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vfs: Use static_decl_vfs in all VFS modules</title>
<updated>2017-12-18T12:31:59+00:00</updated>
<author>
<name>Christof Schmitt</name>
<email>cs@samba.org</email>
</author>
<published>2017-12-15T22:32:12+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=4003736a3d663e39beeabe3d3d9bdffdeca2b570'/>
<id>4003736a3d663e39beeabe3d3d9bdffdeca2b570</id>
<content type='text'>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;

Autobuild-User(master): Andrew Bartlett &lt;abartlet@samba.org&gt;
Autobuild-Date(master): Mon Dec 18 13:32:00 CET 2017 on sn-devel-144
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;

Autobuild-User(master): Andrew Bartlett &lt;abartlet@samba.org&gt;
Autobuild-Date(master): Mon Dec 18 13:32:00 CET 2017 on sn-devel-144
</pre>
</div>
</content>
</entry>
</feed>
