samba.git/source3/modules, branch master

vfs_ceph_new: remove double-cleanup in closedir

2026-04-21T22:18:42+00:00

vfs_ceph_release_fh() was called explicitly then again via the FSP
extension destructor triggered by vfs_ceph_remove_fh(). Drop the
explicit call and let the destructor handle cleanup.

Signed-off-by: Shweta Sodani 
Reviewed-by: Anoop C S 
Reviewed-by: John Mulligan 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Tue Apr 21 22:18:42 UTC 2026 on atb-devel-224

vfs_ceph_new: fix return type mismatch in disk_free

2026-04-21T21:15:30+00:00

-ENOMEM cast to uint64_t is not the error sentinel UINT64_MAX and
leaves errno unset. Set errno and return UINT64_MAX instead.
Also replace UINT64_MAX instead of (uint64_t)-1) in all error path.

Signed-off-by: Shweta Sodani 
Reviewed-by: Anoop C S 
Reviewed-by: John Mulligan

vfs_ceph_new: fix END_PROFILE/END_PROFILE_X mismatch in ftruncate

2026-04-21T21:15:30+00:00

END_PROFILE omits the per-service counter; replace with END_PROFILE_X
to match the START_PROFILE_X on the strict_allocate path.

Signed-off-by: Shweta Sodani 
Reviewed-by: Anoop C S 
Reviewed-by: John Mulligan

vfs_gpfs: convert smb2gpfs_acl() to use talloc

2026-04-18T20:58:22+00:00

This avoids mixing malloc and talloc allocation patterns and
aligns the code with Samba's memory management conventions.

Signed-off-by: Shwetha Acharya 
Reviewed-by: Anoop C S 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Sat Apr 18 20:58:22 UTC 2026 on atb-devel-224

s3/modules: fix snapper_gmt_fstatat

2026-04-15T15:29:37+00:00

snapper_gmt_fstatat is failing when called on items in a
'previous version' snapshot because the wrong timestamp value is
passed (the raw timewarp value is used) and snapper_gmt_convert cannot
find the valid snapshot instance to use.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=16058

Signed-off-by: Noel Power 
Reviewed-by: Anoop C S 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Wed Apr 15 15:29:38 UTC 2026 on atb-devel-224

s3/modules: Fix vfs snapper not finding files in subdirs

2026-04-15T14:25:29+00:00

when trying to browse on windows a snapper share (exposed via windows previous versions) files in subdirs are not visible. In other words only files that are in the root dir of the versioned share can be seen

/ashare/file1
/ashare/file2
/ashare/subdir
/ashare/subdir/subfile1

For example with the file hierarchy above only file1, file2 and subdir are visible. Navigating into subdir shows an empty dir

snapper_gmt_openat is failing because when calling snapper_gmt_convert
it doesn't take into account the path to the subdirectory.
snapper_gmt_convert is just passed the leaf name where it constructs the
snapper path based on the base dir of the share.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=16058

Signed-off-by: Noel Power 
Reviewed-by: Anoop C S

vfs_glusterfs: fix directory fd leak via FSP extension destructor

2026-04-08T16:46:12+00:00

When Samba closes a directory backed by vfs_glusterfs, the glfs_fd_t
opened by vfs_gluster_openat() is never closed.  This leaks one
libgfapi file descriptor and one server-side fd_t in glusterfsd per
directory open/close cycle.  With persistent SMB2 connections the
leak is unbounded and drives monotonic RSS growth on the GlusterFS
brick process.

The leak happens because vfs_glusterfs creates two independent
glfs_fd_t handles per directory: one via glfs_open() in
vfs_gluster_openat(), stored in the FSP extension, and another via
glfs_opendir() in vfs_gluster_fdopendir(), tracked by struct smb_Dir.
On close, smb_Dir_destructor() closes the opendir handle and sets the
pathref fd to -1.  fd_close() then returns early without calling
SMB_VFS_CLOSE, so vfs_gluster_close() never runs and the glfs_open()
handle is orphaned.  The original code passed NULL as the destroy
callback to VFS_ADD_FSP_EXTENSION, so there was no safety net.

The default VFS does not have this problem because fdopendir(3) wraps
the existing kernel fd rather than opening a new handle.  libgfapi
has no equivalent -- glfs_opendir() always creates an independent
handle by path.  The actual glfs_fd_t is stored in the FSP extension,
not in fsp->fh->fd (which holds a sentinel value), so Samba's generic
close path cannot reach it.

Register vfs_gluster_fsp_ext_destroy() as the FSP extension destroy
callback.  It calls glfs_close() on the stored pointer and is invoked
by vfs_remove_all_fsp_extensions() during file_free(), which runs
unconditionally for every fsp.  In the explicit close path,
vfs_gluster_close() NULLs the extension pointer before calling
VFS_REMOVE_FSP_EXTENSION to prevent double-close.  This follows the
same pattern used by vfs_ceph_new.c (vfs_ceph_fsp_ext_destroy_cb).

Observed on a production file server with persistent SMB2 connections
and continuous directory operations.  GlusterFS brick statedumps
showed fd_t pool growth from 1,993 to 80,350 active instances over
6 days, roughly 13,000 leaked fds per day per brick.

RN: Fix a directory file descriptor leak in vfs_glusterfs that caused
unbounded memory growth on the GlusterFS brick with persistent SMB2
connections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=16043

Signed-off-by: Thales Antunes de Oliveira Barretto 
Reviewed-by: Anoop C S 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Apr  8 16:46:12 UTC 2026 on atb-devel-224

vfs_ceph_new: fix errno handling in vfs_ceph_readdir

2026-04-02T05:49:13+00:00

Signed-off-by: Shweta Sodani 
Reviewed-by: Anoop C S 
Reviewed-by: John Mulligan 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Thu Apr  2 05:49:13 UTC 2026 on atb-devel-224

vfs_ceph_new: add missing sentinel to enum_vfs_cephfs_fscrypt_vals

2026-04-02T04:46:29+00:00

Signed-off-by: Shweta Sodani 
Reviewed-by: Anoop C S 
Reviewed-by: John Mulligan

vfs_ceph_new: do not set negative value in vfs_aio_state.error

2026-03-26T09:23:11+00:00

Ceph uses negative error valuers but Samba's VFS expects error value as
non-negative values (errno style).

Signed-off-by: Shachar Sharon 
Reviewed-by: Avan Thakkar 
Reviewed-by: Shweta Sodani 
Reviewed-by: Vinit Agnihotri 
Reviewed-by: Anoop C S 
Reviewed-by: John Mulligan 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Thu Mar 26 09:23:11 UTC 2026 on atb-devel-224