samba.git/source3/param, branch talloc-2.3.0

s3/param: clang: Fix 'Value stored to 'bRetval' is never read'

2019-07-16T22:52:24+00:00

Fixes:

source3/param/loadparm.c:2770:2: warning: Value stored to 'bRetval' is never read <--[clang]
        bRetval = false;
        ^         ~~~~~
source3/param/loadparm.c:3868:2: warning: Value stored to 'bRetval' is never read <--[clang]
        bRetval = false;
        ^         ~~~~~
2 warnings generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

docs/xml: change default for "mangled names" to "illegal"

2019-07-08T16:22:38+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

docs-xml: change "client min protocol" to SMB2_02

2019-07-08T16:22:38+00:00

It's time to disable SMB1 by default...

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

docs-xml: change "server min protocol" to SMB2_02

2019-07-08T16:22:37+00:00

SMB2_02 was available with Windows Vista.
It's time to turn SMB1 off by default.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

param: change default of "allocation roundup size" to 0

2019-07-07T21:32:25+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Christof Schmitt

s3:loadparm: Ensure to truncate FS Volume Label at multibyte boundary

2019-05-16T17:55:18+00:00

For FS_VOLUME_INFO/FS_INFO operation, a maximum of 32 characters are
sent back. However, since Samba chops off any share name with >32
bytes at 32, it is possible that a multi-byte share name can get chopped
off between a full character. This causes the string decoding for unicode
failure which sends back NT_STATUS_ILLEGAL_CHARACTER (EILSEQ) to the client
applications.

On Windows, Notepad doesn't like it, and refuses to open a file in this
case and fails with the following error:

  Invalid character. For multibyte character sets, only the leading byte is
  included without the trailing byte. For Unicode character sets, include
  the characters 0xFFFF and 0xFFFE.

Proposed fix:
- Find the last starting point of a multibyte codepoint if the character
  at 32nd byte is a subsequent byte of a MB codepoint.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13947

Signed-off-by: Shyamsunder Rathi 
Reviewed-by: Hemanth Thummala 
Reviewed-by: Jeremy Allison 
Reviewed-by: Andreas Schneider

s3: squash 'cast between incompatible function types' warning

2019-05-16T17:55:17+00:00

Some functions (e.g. py_smb_savefile) have an extra unecessary
*kwargs param in their signatures, these definitions are
causing 'cast between incompatible function types' warnings when
compiled with -Wcast-function-type. Some other functions have
the *kwargs which causes "cast between incompatible function types'
warnings which need to be squashed with use of the
PY_DISCARD_FUNC_SIG macro.

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

smbd: Move deadtime default to parameter definition and man page

2019-05-01T03:12:07+00:00

The code has a default of one week (10080 minutes) if the parameter is
set to 0. Make this the public default of the parameter, instead of
hiding it in the code. This change also has the code match the
documentation that setting this parameter to 0 disables the check.

Signed-off-by: Christof Schmitt 
Reviewed-by: Andrew Bartlett

memcache: Increase size of default memcache to 512k

2019-04-06T05:12:21+00:00

With the fixed accounting of talloc objects, the default cache size
needs to increase. The exact increase required depends on the workloads,
going form 256k to 512k seems like a reasonable guess.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13865

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

build: Remove bld.gen_python_environments()

2019-03-21T04:06:14+00:00

This was part of --extra-python support.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam