samba.git/source3/passdb/machine_account_secrets.c, branch talloc-2.4.2

s3:passdb: Fix memory leak caused by recursion of get_global_sam_sid()

2024-01-23T14:30:58+00:00

Direct leak of 68 byte(s) in 1 object(s) allocated from:
    #0 0x7f4f39cdc03f in malloc (/lib64/libasan.so.8+0xdc03f) (BuildId: 3e1694ad218c99a8b1b69231666a27df63cf19d0)
    #1 0x7f4f36fbe427 in malloc_ ../../source3/lib/util_malloc.c:38
    #2 0x7f4f394b5e19 in pdb_generate_sam_sid ../../source3/passdb/machine_sid.c:90
    #3 0x7f4f394b5e19 in get_global_sam_sid ../../source3/passdb/machine_sid.c:211
    #4 0x7f4f394af366 in secrets_store_domain_sid ../../source3/passdb/machine_account_secrets.c:143
    #5 0x7f4f394b5eb5 in pdb_generate_sam_sid ../../source3/passdb/machine_sid.c:110
    #6 0x7f4f394b5eb5 in get_global_sam_sid ../../source3/passdb/machine_sid.c:211
    #7 0x7f4f394af366 in secrets_store_domain_sid ../../source3/passdb/machine_account_secrets.c:143
    #8 0x557a1f11d62c in net_setlocalsid ../../source3/utils/net.c:416
    #9 0x557a1f1c9972 in net_run_function ../../source3/utils/net_util.c:464
    #10 0x557a1f121129 in main ../../source3/utils/net.c:1372
    #11 0x7f4f34c281af in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jan 23 14:30:58 UTC 2024 on atb-devel-224

s3:passdb: Fix code spelling

2023-07-19T09:58:37+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Joseph Sutton

s3:passdb: Zero secrets_domain_info1_password created via secrets_domain_info_password_create()

2022-08-26T07:59:32+00:00

Zero out these members of struct secrets_domain_info1_password:

DATA_BLOB cleartext_blob;
struct samr_Password nt_hash;
struct secrets_domain_info1_kerberos_key *keys;

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:passdb: Zero secrets_domain_info1_password created via secrets_fetch()

2022-08-26T07:59:32+00:00

Zero out these members of struct secrets_domain_info1_password:

DATA_BLOB cleartext_blob;
struct samr_Password nt_hash;
struct secrets_domain_info1_kerberos_key *keys;

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:passdb: Zero local memory in secrets_domain_info_kerberos_keys()

2022-08-26T07:59:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:passdb: Zero memory using BURN_FREE_STR() in secrets_fetch_or_upgrade_domain_info()

2022-08-26T07:59:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:passdb: Zero memory using BURN_FREE() in secrets_fetch_trust_account_password_legacy() and secrets_fetch_domain_info1_by_key()

2022-08-26T07:59:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:passdb: Remove unused function secrets_fetch_trust_account_password()

2022-08-08T19:03:08+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Mon Aug  8 19:03:08 UTC 2022 on sn-devel-184

librpc:ndr: Update ndr_print_debug() to the new ndr ABI

2022-07-15T14:25:38+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:passdb: Fix trailing whitespaces in machine_account_secrets.c

2022-07-15T14:25:37+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider