samba.git/source3/passdb, branch master

s3/passdb: add parameter to control handling of wellknown SIDs in pdb_tdb

2026-02-20T15:20:31+00:00

With "tdbsam:map wellknown", one can control if pdb_tdb should be used
to map entries of wellknown SIDs or not. By default, they will not be
mapped, as in previous releases.

This is similar to commit 6a048b424a2ecf38614aa6912f0d8c8a26c87ad5
which added the option "tdbsam:map builtin" for the builtin groups.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Feb 20 15:20:31 UTC 2026 on atb-devel-224

auth: Use new data_blob_..._s() functions and remove talloc_keep_secret()

2025-12-08T17:18:29+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3: talloc_destroy() -> TALLOC_FREE()

2025-11-10T13:29:30+00:00

Sweeping change, I know. Should not change compiled code in most
cases, the compiler should be smart enough to elide the assignment
right before a return. In the cases where this is not right before the
return, TALLOC_FREE() is safer as it makes use-after-free crash.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

s3:passdb: Fix memory leak in pdb_default_del_groupmem()

2025-10-22T15:21:22+00:00

Indirect leak of 496 byte(s) in 1 object(s) allocated from:
    #0 0x7f1e45121c2b in malloc (/lib64/libasan.so.8+0x121c2b) (BuildId: 388ee9ac193f74c177c6f52988d2d0dab110de41)
    #1 0x7f1e44b586a0 in __talloc_with_prefix ../../lib/talloc/talloc.c:783
    #2 0x7f1e44b59f75 in __talloc ../../lib/talloc/talloc.c:825
    #3 0x7f1e44b59f75 in _talloc_named_const ../../lib/talloc/talloc.c:982
    #4 0x7f1e44b59f75 in _talloc_zero ../../lib/talloc/talloc.c:2421
    #5 0x7f1e42a18460 in samu_new ../../source3/passdb/passdb.c:63
    #6 0x7f1e42a381ef in pdb_default_del_groupmem ../../source3/passdb/pdb_interface.c:1098
    #7 0x7f1e42a364b1 in pdb_del_groupmem ../../source3/passdb/pdb_interface.c:1130
    #8 0x000000388a57 in net_sam_delmem ../../source3/utils/net_sam.c:1324
    #9 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451
    #10 0x00000038bfb6 in net_sam ../../source3/utils/net_sam.c:2306
    #11 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451
    #12 0x0000002ea182 in main ../../source3/utils/net.c:1474
    #13 0x7f1e3fc2b2fa in __libc_start_call_main (/lib64/libc.so.6+0x2b2fa) (BuildId: 8523b213e7586a93ab00f6dd476418b1e521e62c)
    #14 0x7ffe6b22b79f  ([stack]+0x2079f)

Signed-off-by: Andreas Schneider 
Reviewed-by: Anoop C S 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Wed Oct 22 15:21:22 UTC 2025 on atb-devel-224

s3:passdb: Fix memory leak in pdb_default_add_groupmem()

2025-10-22T14:18:36+00:00

Indirect leak of 496 byte(s) in 1 object(s) allocated from:
    #0 0x7f068f921c2b in malloc (/lib64/libasan.so.8+0x121c2b) (BuildId: 388ee9ac193f74c177c6f52988d2d0dab110de41)
    #1 0x7f068f4266a0 in __talloc_with_prefix ../../lib/talloc/talloc.c:783
    #2 0x7f068f427f75 in __talloc ../../lib/talloc/talloc.c:825
    #3 0x7f068f427f75 in _talloc_named_const ../../lib/talloc/talloc.c:982
    #4 0x7f068f427f75 in _talloc_zero ../../lib/talloc/talloc.c:2421
    #5 0x7f068cbba260 in samu_new ../../source3/passdb/passdb.c:63
    #6 0x7f068cbda444 in pdb_default_add_groupmem ../../source3/passdb/pdb_interface.c:1022
    #7 0x7f068cbd825d in pdb_add_groupmem ../../source3/passdb/pdb_interface.c:1054
    #8 0x000000389322 in net_sam_addmem ../../source3/utils/net_sam.c:1255
    #9 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451
    #10 0x00000038bfb6 in net_sam ../../source3/utils/net_sam.c:2306
    #11 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451
    #12 0x0000002ea182 in main ../../source3/utils/net.c:1474
    #13 0x7f068a42b2fa in __libc_start_call_main (/lib64/libc.so.6+0x2b2fa) (BuildId: 8523b213e7586a93ab00f6dd476418b1e521e62c)
    #14 0x7ffe0a90b7a1  ([stack]+0x207a1)

Signed-off-by: Andreas Schneider 
Reviewed-by: Anoop C S

passdb: Fixing CID 1509029 for time_t in DEBUG statement

2025-09-24T06:44:50+00:00

In the most likely scenario of time_t being 64 bit signed, we do the
typecast to intmax_t to also log negative values correctly.

Signed-off-by: Rabinarayan Panigrahi 
Reviewed-by: Andreas Schneider 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Anoop C S 
Reviewed-by: Vinit Agnihotri 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Wed Sep 24 06:44:50 UTC 2025 on atb-devel-224

source3/passdb: Follow up to the fix for CID 1508970

2025-09-10T15:23:08+00:00

Fixing another occurrence for the same CID in the same DEBUG statement.
See the previous commit c25a5a26a1cba698420fb64e23bee3b52540b21b.

Signed-off-by: Anoop C S 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Wed Sep 10 15:23:08 UTC 2025 on atb-devel-224

passdb: Fixing CID 1508971 for time_t in DEBUG statement

2025-09-10T09:38:30+00:00

Fix: typecast changing from (unsigned int)badtime  to (intmax_t)badtime
as intmax_t can hold epoch seconds after 2038 year

Signed-off-by: Rabinarayan Panigrahi 
Reviewed-by: Signed-off-by: Martin Schwenke 
Reviewed-by: Andreas Schneider

passdb: Fixing CID 1508970 for time_t in DEBUG statement

2025-09-10T09:38:30+00:00

Fix: typecast changing from (unsigned int)entry->bad_password_time  to
(intmax_t)entry->bad_password_time as intmax_t can hold epoch seconds
after 2038 year

Signed-off-by: Rabinarayan Panigrahi 
Reviewed-by: Signed-off-by: Martin Schwenke 
Reviewed-by: Andreas Schneider

s3:net: Pass down the server from cmdline to sync_pw2keytabs()

2025-09-05T13:38:33+00:00

This makes sure that during 'net ads join' the keytab create code
- sync_pw2keytabs() talks to the same DC at what the machine account
was created.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15905

Signed-off-by: Andreas Schneider 
Signed-off-by: Pavel Filipenský 
Pair-Programmed-With: Pavel Filipenský 

Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Pavel Filipensky 
Autobuild-Date(master): Fri Sep  5 13:38:33 UTC 2025 on atb-devel-224