samba.git/source3/passdb, branch talloc-2.3.1

s3/passdb: clang: Fix 'Value stored during initialization is never read'

2019-10-08T02:40:24+00:00

Fixes:

source3/passdb/pdb_ldap.c:1933:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
                 ^~~   ~~~~~~~~~~~~~~~~~~~~~~
source3/passdb/pdb_ldap.c:4094:11: warning: Value stored to 'ntstatus' during its initialization is never read <--[clang]
        NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
                 ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Oct  8 02:40:24 UTC 2019 on sn-devel-184

s3: passdb: ret doesn't seem to be needed at all

2019-10-01T00:28:44+00:00

I was looking at the wrong hunk when examining this, ret seems redundant
and the existing status can cover things

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Oct  1 00:28:44 UTC 2019 on sn-devel-184

s3/passdb: clang: Value stored to 'c' is never read

2019-09-26T18:41:28+00:00

source3/passdb/pdb_smbpasswd.c:405:4: warning: Value stored to 'c' is never read <--[clang]
                        c = '\0';
                        ^   ~~~~
/home/samba/samba/source3/passdb/pdb_smbpasswd.c:809:4: warning: Value stored to 'c' is never read <--[clang]
                        c = '\0';
                        ^   ~~~~
2 warnings generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/passdb: clang: Fix warning: Value stored to 'acct_ctrl' is never read

2019-09-26T18:41:28+00:00

Fixes:

source3/passdb/pdb_ldap.c:922:3: warning: Value stored to 'acct_ctrl' is never read <--[clang]
                acct_ctrl |= ACB_NORMAL;
                ^            ~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/passed: clang: Fix 'Value stored during its initialization is never read'

2019-09-26T18:41:27+00:00

Fixes:

source3/passdb/passdb.c:2502:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/passdb: clang: Fix 'Value stored during its initialization is never read'

2019-09-26T18:41:27+00:00

Fixes:

source3/passdb/lookup_sid.c:836:11: warning: Value stored to 'result' during its initialization is never read <--[clang]
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/passdb: clang: Fix 'Value stored during initialization is never read'

2019-09-26T18:41:26+00:00

Fixes:

source3/passdb/pdb_interface.c:65:34: warning: Value stored to 'entry' during its initialization is never read <--[clang]
        struct pdb_init_function_entry *entry = backends;
                                        ^~~~~   ~~~~~~~~

/source3/passdb/pdb_interface.c:140:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
        NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
                 ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/passdb: clang: Fix 'Value stored during initialization is never read'

2019-09-26T18:41:26+00:00

Fixes:

source3/passdb/pdb_tdb.c:718:18: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
        NTSTATUS        nt_status = NT_STATUS_UNSUCCESSFUL;
                        ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/passdb: clang: Fix 'Value stored during its initialization is never read'

2019-09-26T18:41:26+00:00

Fixes:

source3/passdb/pdb_util.c:41:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3:passdb: Use generate_secret_buffer() for generating passwords

2019-08-14T15:07:24+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy