samba.git/source3/printing/print_generic.c, branch talloc-2.4.2

source3: move lib/substitute.c functions out of proto.h

2021-11-11T13:49:32+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14897

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider

printing: Simplify calling print commands

2021-05-11T22:56:37+00:00

We have fstr_sprintf for this

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

printing: Fix typos

2021-03-24T20:31:30+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3:param: make "servicename" a substituted option

2019-11-27T10:25:37+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

printing: use lpcfg_substituted_string() in print_run_command()

2019-11-27T10:25:37+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

smbdotconf: mark "printername" with substitution="1"

2019-11-27T10:25:33+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

s3:printing: Fix %J substition

2019-11-07T16:01:21+00:00

print_run_command() uses lp_print_command() which internally performs basic
substition by calling talloc_sub_basic(). As a result. any of the variables in
the "basic set", including "%J" are already substituted.

To prevent the unwanted subtitution, we declare all affected configuration
options as const, which disabled the basic substition.

As a result print_run_command() can run manual substitution on all characters,
including %J, in the variadic argument list *before* calling lp_string() to run
basic substition which we had disabled before with the const.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu Nov  7 16:01:21 UTC 2019 on sn-devel-184

s3:printing: add a DEBUG statement

2019-11-07T14:16:42+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider

s3: rename talloc_sub_advanced() to talloc_sub_full()

2019-11-07T14:16:41+00:00

We currently have the following substitution functions:

  talloc_sub_basic()
  talloc_sub_advanced()

talloc_sub_basic() currently substitutes a subset of talloc_sub_advanced().

We'll need a function X that only substitutes what talloc_sub_advanced()
substitutes *without* what talloc_sub_basic() does.

To get there rename talloc_sub_advanced() to talloc_sub_full(). A subsequent
commit will then bring back talloc_sub_advanced() as described above.

Examples with fictional replacement letters A and B. Currently:

  talloc_sub_basic:    A
  talloc_sub_advanced: AB

New:

  talloc_sub_basic:    A
  talloc_sub_advanced:  B
  talloc_sub_full:     AB

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider

printing: Avoid an "extern current_user"

2017-10-27T18:33:25+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison