samba.git/source3/printing/printer_list.c, branch master

s3:printing: make printer_list.tdb none readable for others

2026-04-07T16:12:32+00:00

Signed-off-by: Shwetha Acharya 
Reviewed-by: Xavi Hernandez 
Reviewed-by: Martin Schwenke 
Reviewed-by: Anoop C S 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Tue Apr  7 16:12:32 UTC 2026 on atb-devel-224

s3:printing: Fix code spelling

2023-08-08T04:39:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s3:printing: Add missing newlines to logging messages

2023-08-08T04:39:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s3:printing: Do not clear the printer-list.tdb

2022-06-30T22:08:39+00:00

With the new dcerpc architecture we need to keep printer-list.tdb
around. A spoolss dcerpc call will start rpc-spoolssd which will then
start the background queue process. However in order to enum the
printers we need have a printer-list.tdb. Depending on the number of
printers this task can take several seconds. It is unlinkly that
the printer-list will change all the time, so we might provide outdated
data till it gets refreshed, but this is better than providing no
printer list at all.

If there are a lot of printers, the idle_seconds for the rpc-spoolssd
should be increased so that the background task can finish.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15082

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Jun 30 22:08:39 UTC 2022 on sn-devel-184

printing: Introduce printer_list_printername_exists()

2021-03-16T17:09:31+00:00

Replace pcap_printername_ok(). Slightly different semantics: If the
printer list db has a corrupted record, this is not detected.

Why this patch? pcap_printername_ok() is a simple wrapper around the
tdb accessing function, and this reduces a dependency on pcap.c

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Pass mem_ctx to lock_path()

2018-08-17T09:30:10+00:00

Fix a confusing API: Many places TALLOC_FREE the path where it's not
clear you have to do it.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

printer_list: don't leak lock_path onto talloc tos

2014-11-03T22:46:05+00:00

Also check for allocation failures.

Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison

printer_list: fix talloc tos leak of tdb record

2014-10-07T17:25:09+00:00

Reported-by: Franz Pförtsch 
Signed-off-by: David Disseldorp 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Oct  7 19:25:09 CEST 2014 on sn-devel-104

printing: traverse_read the printer list for share updates

2014-08-08T12:10:38+00:00

The printcap update procedure involves the background printer process
obtaining the printcap information from the printing backend, writing
this to printer_list.tdb, and then notifying all smbd processes of the
new list. The processes then all attempt to simultaneously traverse
printer_list.tdb, in order to update their local share lists.

With a large number of printers, and a large number of per-client smbd
processes, this traversal results in significant lock contention, mostly
due to the fact that the traversal is unnecessarily done with an
exclusive (write) lock on the printer_list.tdb database.

This commit changes the share update code path to perform a read-only
traversal.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Reported-by: Alex K 
Reported-by: Franz Pförtsch 
Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

s3-printing: Fix obvious memory leak in printer_list_get_printer().

2014-02-25T12:19:37+00:00

https://bugzilla.samba.org/show_bug.cgi?id=9993

Signed-off-by: Jeremy Allison 
Reviewed-by: Ira Cooper 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Feb 25 13:19:37 CET 2014 on sn-devel-104