samba.git/source3/printing/queue_process.c, branch master

s3:printing: Load the shares for [printers] in samba-bgqd

2025-11-14T14:00:31+00:00

One of the main functions of bgqd is:

        delete_and_reload_printers_full()

It isn't able to do its work, if we don't load the shares. Normally bgqd was
forked from smbd and this loaded the shares. But with the introduction of
samba-dcerpcd it is a standalone service now. As a standalone service it is
responsible to load the shares if it needs to work on them.

The following message is printed if delete_and_reload_printers_full() tries to
do its job:

[2025/10/23 09:57:27,  7, pid=41935, effective(0, 0), real(0, 0)] ../../source3/param/loadparm.c:4419(lp_servicenumber)
  lp_servicenumber: couldn't find printers
[2025/10/23 09:57:27,  7, pid=41935, effective(0, 0), real(0, 0)] ../../source3/param/loadparm.c:4419(lp_servicenumber)
  lp_servicenumber: couldn't find printers

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15936

Signed-off-by: Andreas Schneider 
Reviewed-by: Anoop C S

s3: SIGHUP handlers use consistent log level 3

2024-09-25T01:38:02+00:00

When turn-on 'log level = 3', sending SIGHUP to samba processes, for
example: smbd parent/children, smbd-notifyd, and smbd-cleanupd. Then
monitor log.smbd in order to parse sighup logs, it looks like the log level
is inconsistent among these processes: smbd parent/children use level 1,
and smbd-notifyd/smbd-cleanupd use level 3.

This patch raises sighup handler's log level from level 1 to level 3, which
is more consistent with smbd-notifyd by Commit 6e5bff80a0a0b ("s3:notifyd:
Handle sigup in notifyd to reparse smb.conf"), and smbd-cleanupd by Commit
57c1e115ecef4 ("smbd: reopen logs on SIGHUP for notifyd and cleanupd").

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15706

Signed-off-by: Jones Syue 
Reviewed-by: Jeremy Allison 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Wed Sep 25 01:38:02 UTC 2024 on atb-devel-224

lib: Remove timeval_set()

2024-03-22T06:07:42+00:00

We have the same function in tevent, no need to duplicate code. More lines just
due to clang-format.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri Mar 22 06:07:42 UTC 2024 on atb-devel-224

s3:printing: Start samba-bgqd as soon as possible

2022-05-31T21:51:07+00:00

We need some time to fill the printcap cache.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15081

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue May 31 21:51:07 UTC 2022 on sn-devel-184

s3:printing: Initialize the printcap cache as soon as the bgqd starts

2022-05-31T20:53:35+00:00

As soon as the background daemon starts, we need to initialize the
printcap cache so that rpcd-spoolssd can serve printers.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15081

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

printing: Remove "start_daemons" from printing_subsystem_init()

2021-12-10T14:02:30+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

s3:rpc_server: Activate samba-dcerpcd

2021-12-10T14:02:30+00:00

This is the big switch to use samba-dcerpcd for the RPC services in
source3/. It is a pretty big and unordered patch, but I don't see a
good way to split this up into more manageable pieces without
sacrificing bisectability even more. Probably I could cut out a few
small ones, but a major architechtural switch like this will always be
messy.

Signed-off-by: Volker Lendecke 
Reviewed-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 
Reviewed-by: Stefan Metzmacher

source3/printing/queue_process.c: fix build on macOS

2021-10-13T01:42:35+00:00

On macOS environ is defined to (*_NSGetEnviron()) in lib/replace/replace.h
and otherwise the `extern char **environ` can be found there.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14862

Signed-off-by: Alex Richardson 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Jeremy Allison

printing: Avoid a few references to background_lpq_updater_pid

2021-05-11T23:45:21+00:00

We have the bgqd in the pidfile now

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue May 11 23:45:21 UTC 2021 on sn-devel-184

printing: Introduce samba-bgqd

2021-05-11T22:56:37+00:00

This is a separate binary executed from start_background_queue(). As
such it does not really gain much, but the idea is to move all the
code this runs out of the smbd and spoolssd binaries to just link
here.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison