samba.git/source3/profile, branch talloc-2.2.0

profiling: stop smbprofile from growing unnecessarily

2019-01-16T01:01:55+00:00

Signed-off-by: Dylan Stephano-Shachter 
Reviewed-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Jan 16 02:01:55 CET 2019 on sn-devel-144

lib: Pass mem_ctx to cache_path()

2018-08-17T12:28:51+00:00

Fix a confusing API: Many places TALLOC_FREE the path where it's not
clear you have to do it.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Aug 17 14:28:51 CEST 2018 on sn-devel-144

s3-profile: reduce dependencies of smbprofile.h

2016-03-28T18:45:16+00:00

Signed-off-by: Uri Simchoni 
Reviewed-by: Jeremy Allison

smbprofile: Add dst pid to smbprofile_cleanup

2015-11-16T13:51:33+00:00

The consolidation will soon be done by a separate process. We need to
avoid the getpid() call in smbprofile_cleanup().

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

Convert all uint32/16/8 to _t in a grab-bag of remaining files.

2015-05-14T20:16:56+00:00

I still need to fix the rpc stuff, but we are almost there.

Signed-off-by: Richard Sharpe 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu May 14 22:16:56 CEST 2015 on sn-devel-104

s3:smbprofile: profile the system and user space cpu time

2015-03-06T11:31:10+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3:smbprofile: Replace sysv shmem with tdb

2015-03-06T11:31:10+00:00

What?

This patch gets rid of the central shared memory segment referenced by
"profile_p". Instead, every smbd gets a static profile_area where it collects
profiling data. Once a second, every smbd writes this profiling data into a
record of its own in a "smbprofile.tdb". smbstatus -P does a tdb_traverse on this
database and sums up what it finds.

Why?

At least in my perception sysv IPC has not the best reputation on earth. The
code before this patch uses shmat(). Samba ages ago has developed a good
abstraction of shared memory: It's called tdb.

The main reason why I started this is that I have a request to become
more flexible with profiling data. Samba should be able to collect data
per share or per user, something which is almost impossible to do with
a fixed structure. My idea is to for example install a profile area per
share and every second marshall this into one tdb record indexed by share
name. smbstatus -P would then also collect the data and either aggregate
them or put them into individual per-share statistics. This flexibility
in the data model is not really possible with one fixed structure.

But isn't it slow?

Well, I don't think so. I can't really prove it, but I do believe that on large
boxes atomically incrementing a shared memory value for every SMB does show up
due to NUMA effects. With this patch the hot code path is completely
process-local. Once a second every smbd writes into a central tdb, this of
course does atomic operations. But it's once a second, not on every SMB2 read.

There's two places where I would like to improve things: With the current code
all smbds wake up once a second. With 10,000 potentially idle smbds this will
become noticable. That's why the current only starts the timer when something has
changed.

The second place is the tdb traverse: Right now traverse is blocking in the
sense that when it has to switch hash chains it will block. With mutexes, this
means a syscall. I have a traverse light in mind that works as follows: It
assumes a locked hash chain and then walks the complete chain in one run
without unlocking in between. This way the caller can do nonblocking locks in
the first round and only do blocking locks in a second round. Also, a lot of
syscall overhead will vanish. This way smbstatus -P will have almost zero
impact on normal operations.

Pair-Programmed-With: Stefan Metzmacher 

Signed-off-by: Volker Lendecke 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3:smbprofile: rewrite the internal macros

2014-11-19T19:51:37+00:00

We now autogenerate a lot of code using
SMBPROFILE_STATS_ALL_SECTIONS macro which expands to
different SMBPROFILE_STATS_{COUNT,BASIC,BYTES,IOBYTES} macros.

This also allows async profiling using:

   struct mystate {
       ...

       SMBPROFILE_BASIC_ASYNC_STATE(profile_state);
       ...
   };

   ...

   SMBPROFILE_BASIC_ASYNC_START(SMB2_negotiate, profile_p, mystate->profile_state);

   ...

   SMBPROFILE_BYTES_ASYNC_SET_IDLE(mystate->profile_state);

   ...

   SMBPROFILE_BYTES_ASYNC_SET_BUSY(mystate->profile_state);

   ...

   SMBPROFILE_BASIC_ASYNC_END(mystate->profile_state);

The current START_PROFILE*()/END_PROFILE*() are implemented as legacy wrappers.

Signed-off-by: Stefan Metzmacher

s3:smbprofile: remove unused nmbd related counters

2014-11-19T19:51:36+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

smbd: Fix nonempty line endings

2014-10-07T12:44:04+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: David Disseldorp