samba.git/source3/registry, branch master

s3: talloc_destroy() -> TALLOC_FREE()

2025-11-10T13:29:30+00:00

Sweeping change, I know. Should not change compiled code in most
cases, the compiler should be smart enough to elide the assignment
right before a return. In the cases where this is not right before the
return, TALLOC_FREE() is safer as it makes use-after-free crash.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

rpc registry: add ProductType for AD DC

2025-07-01T09:17:08+00:00

HKLM\SYSTEM\CurrentControlSet\Control\ProductOptions contains a key
ProductType

The value of that key should be LanmanNT on a domain controller (of any
type).
The switch had no case for ROLE_ACTIVE_DIRECTORY_DC

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15863
Signed-off-by: Michael Saxl 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jul  1 09:17:08 UTC 2025 on atb-devel-224

lib: Save lines by avoiding explicit ZERO_STRUCTP calls

2025-05-15T14:03:34+00:00

SMB_CALLOC_ARRAY(..., 1) does this.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

lib: Add a few explicit includes

2024-08-27T07:19:32+00:00

Required to trim down includes from gen_ndr/*security*

Signed-off-by: Volker Lendecke 
Reviewed-by: Jennifer Sutton

s3:registry: Use correct integer sizes

2024-07-08T07:36:32+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke

s3:registry: Check for integer overflow

2024-07-08T07:36:32+00:00

"Error: INTEGER_OVERFLOW (CWE-190):
samba-4.20.0rc2/source3/registry/regfio.c:175: tainted_data_argument: The check ""bytes_read < block_size"" contains the tainted expression ""bytes_read"" which causes ""block_size"" to be considered tainted.
samba-4.20.0rc2/source3/registry/regfio.c:176: overflow: The expression ""block_size - bytes_read"" is deemed overflowed because at least one of its arguments has overflowed.
samba-4.20.0rc2/source3/registry/regfio.c:176: overflow_sink: ""block_size - bytes_read"", which might have underflowed, is passed to ""read(file->fd, buffer + bytes_read, block_size - bytes_read)"". [Note: The source code implementation of the function has been overridden by a builtin model.]
  174|
  175|   	while ( bytes_read < block_size ) {
  176|-> 		if ( (returned = read( file->fd, buffer+bytes_read, block_size-bytes_read )) == -1 ) {
  177|   			DEBUG(0,(""read_block: read() failed (%s)\n"", strerror(errno) ));
  178|   			return False;"

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke

s3:registry: Initialize struct security_ace ace[]

2024-07-05T07:45:32+00:00

Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/registry/reg_dispatcher.c:43: var_decl: Declaring variable "ace" without initializer.
samba-4.20.0rc2/source3/registry/reg_dispatcher.c:66: uninit_use_in_call: Using uninitialized value "*ace". Field "ace->object" is uninitialized when calling "make_sec_acl".
  64|           /* create the security descriptor */
  65|
  66|->         theacl = make_sec_acl(ctx, NT4_ACL_REVISION, i, ace);
  67|           if (theacl == NULL) {
  68|                   return WERR_NOT_ENOUGH_MEMORY;

Signed-off-by: Pavel Filipenský 
Reviewed-by: Volker Lendecke

s3:registry: Add missing return value checks

2024-06-24T06:14:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Signed-off-by: Martin Schwenke

s3:registry: Avoid possible double frees

2024-06-24T06:14:36+00:00

Found by Covscan.

"Error: USE_AFTER_FREE (CWE-416):
samba-4.20.0rc2/source3/registry/reg_perfcount.c:309: freed_arg: ""_reg_perfcount_multi_sz_from_tdb"" frees ""*retbuf"".
samba-4.20.0rc2/source3/registry/reg_perfcount.c:313: double_free: Calling ""_reg_perfcount_multi_sz_from_tdb"" frees pointer ""*retbuf"" which has already been freed.
  311|   	for(i = 1; i <= base_index; i++)
  312|   	{
  313|-> 		buffer_size = _reg_perfcount_multi_sz_from_tdb(names, i*2, retbuf, buffer_size);
  314|   	}
  315|   	tdb_close(names);"

Signed-off-by: Andreas Schneider 
Reviewed-by: Signed-off-by: Martin Schwenke

s3:registry: Remove trailing spaces in reg_perfcount.c

2024-06-24T06:14:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Signed-off-by: Martin Schwenke