samba.git/source3/rpc_server/svcctl, branch master

s3:rpc_server: Initialize array

2024-07-08T08:37:46+00:00

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/rpc_server/svcctl/srv_svcctl_nt.c:163: var_decl: Declaring variable ""ace"" without initializer.
samba-4.20.0rc2/source3/rpc_server/svcctl/srv_svcctl_nt.c:182: uninit_use_in_call: Using uninitialized value ""*ace"". Field ""ace->object"" is uninitialized when calling ""make_sec_acl"".
  180|   	/* create the security descriptor */
  181|
  182|-> 	if ( !(theacl = make_sec_acl(ctx, NT4_ACL_REVISION, i, ace)) )
  183|   		return NULL;
  184|"

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Mon Jul  8 08:37:46 UTC 2024 on atb-devel-224

librpc: add various new commands and types to SVCCTL IDL.

2023-11-09T08:00:30+00:00

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andrew Bartlett

svcctl: rename SERVICE_FAILURE_ACTIONS to SERVICE_FAILURE_ACTIONSW

2023-11-09T08:00:30+00:00

(there will be a SERVICE_FAILURE_ACTIONSA variant also)

Guenther

Signed-off-by: Günther Deschner 
Reviewed-by: Andrew Bartlett

svcctl: unify operation names and always prefix with svcctl_

2023-11-09T08:00:30+00:00

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andrew Bartlett

s3:rpc_server: Fix inverted error messages

2023-09-14T21:35:29+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

rpc_server3: Remove pipes_struct->session_info

2022-01-05T00:11:38+00:00

This is a big patch, but all it does is replace all "p->session_info"
with "session_info" after introducing a local variable from
dcesrv_call_session_info(p->dce_call).

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3:rpc_server: Activate samba-dcerpcd

2021-12-10T14:02:30+00:00

This is the big switch to use samba-dcerpcd for the RPC services in
source3/. It is a pretty big and unordered patch, but I don't see a
good way to split this up into more manageable pieces without
sacrificing bisectability even more. Probably I could cut out a few
small ones, but a major architechtural switch like this will always be
messy.

Signed-off-by: Volker Lendecke 
Reviewed-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 
Reviewed-by: Stefan Metzmacher

s3:rpc_server: Remove direct registry access from svcctl_init_winreg

2021-12-10T14:02:30+00:00

Once we do registry access via a pipe into a different process, a
registry client won't be able to directly do registry transactions
anymore. In this case, I argue that doing this in a transactioned way
is overkill anyway. svcctl_init_winreg() just sets up some registry
keys, and if that leaves behind some stale entries if it fails
somewhere in the middle, it does not really matter because the only
one looking at these registry keys is the svcctl service, and that
only starts up if the init function was successfully run.

Signed-off-by: Volker Lendecke 
Reviewed-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 
Reviewed-by: Stefan Metzmacher

lib: give global_contexts.c its own header file

2021-01-08T20:31:33+00:00

It's a bit shocking how many references we have to global
contexts. Make this a bit more obvious.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

s3: rpc_server: Avoid casts calling to find_policy_by_hnd()

2020-05-24T23:55:37+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett