samba.git/source3/rpc_server, branch master

s3:srvsvc: guard lp_killservice() in _srvsvc_NetShareDel() with connections_snum_used check

2026-04-14T23:04:37+00:00

_srvsvc_NetShareDel() unconditionally calls lp_killservice() to
destroy the service after deleting a share via RPC. If any active
connection is still using this service number, the destroyed service
can cause a NULL pointer dereference on subsequent requests.

Guard the call with connections_snum_used() so the service is only
freed when no connections are using it. The periodic
load_usershare_shares() sweep will clean up the stale service once
all connections have disconnected.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14978

Co-Authored-By: Claude Opus 4.6 (1M context) 

Signed-off-by: Jeremy Allison 
Reviewed-by: David Mulder

s3/rpc_server: Add worker status smbcontrol message support

2026-04-14T12:12:07+00:00

Add information about the number of connections a rpc_worker
process is handling and when each connection was initiated.

command
  smbcontrol 55063 rpc-dump-worker-status

will output data like below:

  rpcd_spoolss pid 55063:
      num connections = 2
      num_association_groups = 2
      last client connection 2026/03/18 06:51:04.482192
      last client disconnection 2026/03/18 06:51:00.304951
   active connections:
      [1] endpoint=ncacn_np:[\pipe\spoolss] client addr=192.168.32.175 server=priu0002 connected at 2026/03/18 06:51:04.482192
      [2] endpoint=ncacn_np:[\pipe\spoolss] client addr=192.168.33.232 server=priu0002 connected at 2026/03/18 06:47:08.466157

Signed-off-by: Noel Power 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Tue Apr 14 12:12:07 UTC 2026 on atb-devel-224

rpc_server: Only allocate fsp when counting file locks

2026-04-14T10:02:29+00:00

Avoids creating fsp, which is not needed unless we
are going to count the brlocks.

Also uses early continue and removes num_locks variable
by assigning the result directly.

Signed-off-by: Shwetha Acharya 
Reviewed-by: Xavi Hernandez 
Reviewed-by: Shweta Sodani 
Reviewed-by: Martin Schwenke 
Reviewed-by: Anoop C S 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Tue Apr 14 10:02:29 UTC 2026 on atb-devel-224

rpc_server: Optionally skip "process_exists" when enumerating files

2026-04-14T08:57:30+00:00

If you want to skip the potentially expensive process_exists calls when
enumerating millions of files, set

srvsvc : file enum check stale = false

in your [global] section of your smb.conf

Signed-off-by: Volker Lendecke 
Reviewed-by: Xavi Hernandez 
Reviewed-by: Shweta Sodani 
Reviewed-by: Martin Schwenke 
Reviewed-by: Anoop C S

rpc_server: Optionally skip counting byte range locks when enumerating files

2026-04-14T08:57:30+00:00

Signed-off-by: Ralph Wuerthner 
Reviewed-by: Xavi Hernandez 
Reviewed-by: Shweta Sodani 
Reviewed-by: Martin Schwenke 
Reviewed-by: Anoop C S

s3:rpc_server: make epmdb.tdb non readable for others

2026-04-07T15:09:38+00:00

Signed-off-by: Shwetha Acharya 
Reviewed-by: Xavi Hernandez 
Reviewed-by: Martin Schwenke 
Reviewed-by: Anoop C S

rpc: Don't offer spoolss RPC with "disable spoolss = yes"

2026-03-13T09:00:05+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=16019
Signed-off-by: Volker Lendecke 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Mar 13 09:00:05 UTC 2026 on atb-devel-224

fss_srv: Use create_conn_struct_chdir()

2026-03-01T20:19:35+00:00

This is the last user of the non-chdir create_conn_struct_tos(). While
I don't fully understand the code, this is an RPC server that *should*
not care about the current working directory. There are some tests for
this in the rpc.fsrvp group of tests, so I don't think this breaks too
badly.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

dfssrv: Call create_conn_struct_chdir()

2026-03-01T20:19:35+00:00

This is inside an rpc server, where we don't depend on an implicit
current working directory. We don't need the "jump back to old cwd"
that create_conn_struct_tos_cwd() provided.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

srvsvc: Call create_conn_struct_chdir()

2026-03-01T20:19:35+00:00

This is inside an rpc server, where we don't depend on an implicit
current working directory. We don't need the "jump back to old cwd"
that create_conn_struct_tos_cwd() provided.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S