samba.git/source3/rpc_server, branch talloc-2.3.4

srvsvcd: Silence a integer type warning

2022-05-20T19:59:07+00:00

Okay because lp_csc_policy() is an enum with 4 choices

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri May 20 19:59:07 UTC 2022 on sn-devel-184

srvsvcd: Avoid an "else" due to the early return

2022-05-20T19:02:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

srvsvcd: Directly initialize variables in count_for_all_fn()

2022-05-20T19:02:37+00:00

Easier to read for me

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

srvsvcd: Align integer types

2022-05-20T19:02:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

srvsvcd: Fix shareinfo2 max_connections calculation

2022-05-20T19:02:37+00:00

lp_max_connections() being an int could be >UINT32_MAX

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

srvsvcd: Use UINT32_MAX where appropriate

2022-05-20T19:02:37+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

srvsvc: Announce [username] in NetShareEnum

2022-05-18T17:42:20+00:00

This patch has two flaws: First, it does not cover api_RNetShareEnum()
for SMB1, and the second one is: To make this elegant, we would have
to restructure our share handling. It is really only listing shares
for which we have to pull in everything from smb.conf, registry,
usershares and potentially printers. What we should do is modify our
loadparm handling to only load share definitions on demand and for
listing shares handle all the potential sources specially. Add code
that walks the registry shares without adding them to our services
list and so on.

This patch is the quick&dirty way to fix the bug, the alternative
would be weeks or more. And hopefully nobody notices the SMB1
problem...

Bug: https://bugzilla.samba.org/show_bug.cgi?id=15062

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed May 18 17:42:20 UTC 2022 on sn-devel-184

srvsvc: Add a central return point to init_srv_share_info_ctr()

2022-05-18T16:50:34+00:00

Soon there will be cleanup work to do.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=15062

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

Revert "vfs: remove dirfsp arg from SMB_VFS_CREATE_FILE()"

2022-04-28T13:12:33+00:00

This reverts commit 322574834f1e71bc01f21be9059ca4d386517c84.

Not strictly a revert anymore, but for future work we do need "dirfsp"
in create_file_default() passed through the VFS.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

smbd: remove itime and file_id logic and code

2022-03-31T23:01:37+00:00

This bases File-Ids on the inode numbers again. The whole stuff was
added because at that time Apple clients

1. would be upset by inode number reusage and

2. had a client side bug in their fallback implemetentation that
assigns File-Ids on the client side in case the server provides
File-Ids of 0.

After discussion with folks at Apple it should be safe these days to
rely on the Mac to generate its own File-Ids and let Samba return 0
File-Ids.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison