samba.git/source3/script/tests/printing, branch master

s3:tests: let modprinter.pl use $TMPDIR

2024-07-23T13:53:13+00:00

We should avoid using /tmp in selftest

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Tue Jul 23 13:53:13 UTC 2024 on atb-devel-224

tests: Enable a few tests for FreeBSD

2023-07-03T19:40:35+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3:tests: Reformat printing_var_exp_lpr_cmd.sh

2022-05-02T23:15:37+00:00

shfmt -f source3/script/| xargs shfmt -w -p -i 0 -fn

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3: tests: Change logfile for printing expansion tests.

2021-03-18T02:57:08+00:00

logfile=/tmp/$USER_printing_var_exp.log -> logfile="${SELFTEST_TMPDIR}/${USER}_printing_var_exp.log"

Signed-off-by: Jeremy Allison 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Thu Mar 18 02:57:08 UTC 2021 on sn-devel-184

selftest: fix cleanup of test_printing_var_exp.sh

2021-03-16T22:08:10+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14668

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Mar 16 22:08:10 UTC 2021 on sn-devel-184

selftest: add a test for %U variable expansion in spoolssd

2021-03-11T23:43:32+00:00

This targets the nt4_dc testenv which luckily already runs with spoolssd
enabled.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14668
MR: https://gitlab.com/samba-team/samba/-/merge_requests/1834

Signed-off-by: Ralph Boehme 
Reviewed-by: Björn Baumbach 
Reviewed-by: Jeremy Allison

s3:script: Try to fix a Perl warning

2019-12-19T14:20:41+00:00

Scalar value @ENV{"BASH_ENV"} better written as $ENV{"BASH_ENV"} at
/tmp/samba-testbase/b23/samba-ad-dc-1/source3/script/tests/printing/modprinter.pl
line 134.

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3:script: Fix running cp in modprinter.pl

2019-03-21T16:41:33+00:00

We need to unset BASH_ENV or we get:
    Insecure $ENV{BASH_ENV} while running setgid

Signed-off-by: Andreas Schneider 
Reviewed-by: David Disseldorp 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu Mar 21 16:41:33 UTC 2019 on sn-devel-144

s3:script: Untaint user supplied data in modprinter.pl

2017-08-24T07:30:33+00:00

spoolss_SetPrinter fails because of the error produced by modprinter.pl.

Perl error:
Insecure dependency in open while running setgid at modprinter.pl line 76.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12950

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner

s3-selftest: fix return code for modprinter.pl -a.

2010-02-18T10:23:59+00:00

Background is: the SetPrinter level 2 calls "addprinter command" an fails if a
share already existed (and the addprinter command returned a non-0 return code).
Removing the non-0 return code is fine, as in AddPrinter{Ex}, we have checks to
see if a share already exists before calling out the addprinter command.

Maybe one day, we need to have a "changeprinter command"...

Guenther