samba.git/source3/script, branch talloc-2.4.4 Unnamed repository; edit this file 'description' to name the repository. s3:tests: Use bash and disable history expansion for test_wbinfo_lookuprids_cache.sh 2025-08-05T12:50:07+00:00 Andreas Schneider asn@samba.org 2025-08-05T09:31:59+00:00 43b3ee91b29f32477e5ce65ca2b9f1fed86d39ba Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Aug 5 12:50:07 UTC 2025 on atb-devel-224 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Aug  5 12:50:07 UTC 2025 on atb-devel-224
s3:tests: Fix shellcheck warning of test_wbinfo_lookuprids_cache.sh 2025-08-05T11:50:32+00:00 Andreas Schneider asn@samba.org 2025-08-05T09:11:10+00:00 df35b106c8da2ce563301bd9f41fea0817a91996 In source3/script/tests/test_wbinfo_lookuprids_cache.sh line 27: key=$("$TDBDUMP" "$cache" | grep ^key.*NDR.*/"$opnum"/ | cut -d\" -f2) ^-------------------^ SC2062 (warning): Quote the grep pattern so the shell won't interpret it. Lets better use awk for matching the pattern. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> 
In source3/script/tests/test_wbinfo_lookuprids_cache.sh line 27:
key=$("$TDBDUMP" "$cache" | grep ^key.*NDR.*/"$opnum"/ | cut -d\" -f2)
                                 ^-------------------^ SC2062 (warning):
                                 Quote the grep pattern so the shell won't
                                 interpret it.

Lets better use awk for matching the pattern.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
s3-selftest: fix test_wbinfo_lookuprids_cache.sh 2025-08-02T07:20:38+00:00 Günther Deschner gd@samba.org 2025-07-31T13:35:04+00:00 e5b4b3da35f5117de946f159c9a7739273a4783a This script is using tdbtool for deleting keys of a particular winbind NDR operation for regression testing. There are two issues here: The opnum for this winbind NDR operation has changed (as new calls have been added to the interface), it is no longer 16 but now 17. Better try to lookup the current opnum from the IDL. As tdbtool always returns with success error code regardless of the success of its command - in this case a delete key operation - the test is simply not able to fail at all (patch following to fix tdbtool itself). Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
This script is using tdbtool for deleting keys of a particular
winbind NDR operation for regression testing. There are two issues here:

The opnum for this winbind NDR operation has changed (as new calls have
been added to the interface), it is no longer 16 but now 17. Better try
to lookup the current opnum from the IDL.

As tdbtool always returns with success error code regardless of the
success of its command - in this case a delete key operation - the test
is simply not able to fail at all (patch following to fix tdbtool
itself).

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
s3-selftest: add tests for "net ads kerberos" commands 2025-07-24T16:30:32+00:00 Günther Deschner gd@samba.org 2025-07-20T15:59:37+00:00 18d0574a0fe4b5fd468f949cfaa507ab4519c9e6 BUG: https://bugzilla.samba.org/show_bug.cgi?id=15840 Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15840

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
tests: Replace PREFIX_ABS with PREFIX 2025-07-10T15:17:34+00:00 Pavel Filipenský pfilipensky@samba.org 2025-07-03T21:07:37+00:00 b36a64289c33d579a2229e1bdfcd6932f0cb208e Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> 
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 selftest: Add test for smb_prometheus_endpoint utility 2025-04-11T18:46:41+00:00 Shachar Sharon ssharon@redhat.com 2025-02-05T14:20:10+00:00 cf75acf877940135dea97af2aff9206e335b4736 Basic test for smb_prometheus_endpoint utility. Requires valid metrics output using 'curl'. Start/stop the endpoint utility from within the test script itself. Signed-off-by: Shachar Sharon <ssharon@redhat.com> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> 
Basic test for smb_prometheus_endpoint utility. Requires valid metrics
output using 'curl'. Start/stop the endpoint utility from within the
test script itself.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
smbprofile: add authentication metrics 2025-04-11T18:46:40+00:00 Ralph Boehme slow@samba.org 2024-02-05T17:04:57+00:00 ca937832a000d6e38b3e88a39c6db612ea42f077 "authentication" is the total number of requests and "authentication_failed" is obviously the number of failed authentications. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> 
"authentication" is the total number of requests and "authentication_failed" is
obviously the number of failed authentications.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
smbd: remove get_change_timespec() 2025-03-27T05:37:43+00:00 Ralph Boehme slow@samba.org 2025-03-14T06:59:33+00:00 907f17dda9984dd70af9fd23ab02c21b7c50fbe8 Return ctime from the filesystem instead of mtime. Adjust existing tests by removing ctime check. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13594 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Return ctime from the filesystem instead of mtime. Adjust existing tests
by removing ctime check.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13594

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
s3:libads: Remove specifier for 'host' principal from 'sync machine password to keytab' 2025-02-15T18:24:33+00:00 Pavel Filipenský pfilipensky@samba.org 2025-02-14T16:28:54+00:00 ccc3b2b2fba7b5d223c79bffc0f655490aed19cf Use specifier 'spn_prefixes=host' instead of 'host' BUG: https://bugzilla.samba.org/show_bug.cgi?id=15759 Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> 
Use specifier 'spn_prefixes=host' instead of 'host'

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15759

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
s3: Add new keytab specifiers 2025-02-13T17:42:32+00:00 Pavel Filipenský pfilipensky@samba.org 2025-01-20T15:00:51+00:00 15e191736d3eaba83b2fb4b901e1df2214526b64 BUG: https://bugzilla.samba.org/show_bug.cgi?id=15759 Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15759

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>