<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/source3/services, branch talloc-2.4.2</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>s3:services: Disable rcinit-based service control code</title>
<updated>2021-12-10T14:02:30+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2021-06-14T05:54:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=a60c7b4ff29bc59c0d5a42f14dbe0ae4dbe26192'/>
<id>a60c7b4ff29bc59c0d5a42f14dbe0ae4dbe26192</id>
<content type='text'>
This is a become_root user callout that I have never seen in use in
more than 20 years of Samba. Why disable now? In the next commit I
need to make a change to initializing the registry values for
services, the svcctl service won't be able to do registry transactions
anymore. I'm not sure that going without transactions is 100% safe in
all failure cases, so I decided to propose disabling the problematic
code that might lead to security issues.

One fix might be to add a lot more validation code to
_svcctl_OpenServiceW() to see whether the registry values underlying
the service are sane.

Yes, this is technical debt, but I would question that starting unix
daemons via DCERPC used at all out there.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Samuel Cabrero &lt;scabrero@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Stefan Metzmacher &lt;metze@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a become_root user callout that I have never seen in use in
more than 20 years of Samba. Why disable now? In the next commit I
need to make a change to initializing the registry values for
services, the svcctl service won't be able to do registry transactions
anymore. I'm not sure that going without transactions is 100% safe in
all failure cases, so I decided to propose disabling the problematic
code that might lead to security issues.

One fix might be to add a lot more validation code to
_svcctl_OpenServiceW() to see whether the registry values underlying
the service are sane.

Yes, this is technical debt, but I would question that starting unix
daemons via DCERPC used at all out there.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Samuel Cabrero &lt;scabrero@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Stefan Metzmacher &lt;metze@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>srcctl3: Improve debug messages</title>
<updated>2018-01-16T01:43:03+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2018-01-15T10:42:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=a63aafb05d4d975aa9898b8a2dcbbf5d4f41938d'/>
<id>a63aafb05d4d975aa9898b8a2dcbbf5d4f41938d</id>
<content type='text'>
A customer's syslog was filled with

_svcctl_OpenServiceW: Failed to get a valid security descriptor

messages. This improves the messages to give info about which service failed
with which error code. Also, it makes OpenServiceW fail with the same error
message Windows fails with for unknown services.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Tue Jan 16 02:43:03 CET 2018 on sn-devel-144
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A customer's syslog was filled with

_svcctl_OpenServiceW: Failed to get a valid security descriptor

messages. This improves the messages to give info about which service failed
with which error code. Also, it makes OpenServiceW fail with the same error
message Windows fails with for unknown services.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Tue Jan 16 02:43:03 CET 2018 on sn-devel-144
</pre>
</div>
</content>
</entry>
<entry>
<title>Update smbrun to allow for settings environment variables.</title>
<updated>2016-10-13T02:26:26+00:00</updated>
<author>
<name>Trever L. Adams</name>
<email>trever.adams@gmail.com</email>
</author>
<published>2016-10-12T15:55:15+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=7accec7f78f40849b50ad291fb56b04f3fd39dc2'/>
<id>7accec7f78f40849b50ad291fb56b04f3fd39dc2</id>
<content type='text'>
Signed-off-by: Trever L. Adams &lt;trever.adams@gmail.com&gt;
Reviewed-by: David Disseldorp &lt;ddiss@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Thu Oct 13 04:26:26 CEST 2016 on sn-devel-144
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Trever L. Adams &lt;trever.adams@gmail.com&gt;
Reviewed-by: David Disseldorp &lt;ddiss@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Thu Oct 13 04:26:26 CEST 2016 on sn-devel-144
</pre>
</div>
</content>
</entry>
<entry>
<title>werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/services/</title>
<updated>2016-09-27T22:04:19+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gd@samba.org</email>
</author>
<published>2015-12-03T14:24:16+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=8f39b2fd243c5475fdd22526bec3f65c3e96959d'/>
<id>8f39b2fd243c5475fdd22526bec3f65c3e96959d</id>
<content type='text'>
Guenther

Signed-off-by: Guenther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Guenther

Signed-off-by: Guenther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>werror: replace WERR_BADFILE with WERR_FILE_NOT_FOUND in source3/services/svc_winreg_glue.c</title>
<updated>2016-09-27T22:04:17+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gd@samba.org</email>
</author>
<published>2015-12-03T14:24:11+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=5ad6e8f7deecca2c0b630c2016793498762801e3'/>
<id>5ad6e8f7deecca2c0b630c2016793498762801e3</id>
<content type='text'>
Guenther

Signed-off-by: Guenther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Guenther

Signed-off-by: Guenther Deschner &lt;gd@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Convert all uint32/16/8 to _t in a couple of include files.</title>
<updated>2015-05-12T02:22:55+00:00</updated>
<author>
<name>Richard Sharpe</name>
<email>rsharpe@samba.org</email>
</author>
<published>2015-05-09T22:35:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=bc62dfa493df8a554829900d6bd9686f0ca028b5'/>
<id>bc62dfa493df8a554829900d6bd9686f0ca028b5</id>
<content type='text'>
Signed-off-by: Richard Sharpe &lt;rsharpe@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Tue May 12 04:22:55 CEST 2015 on sn-devel-104
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Richard Sharpe &lt;rsharpe@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Tue May 12 04:22:55 CEST 2015 on sn-devel-104
</pre>
</div>
</content>
</entry>
<entry>
<title>param: Change from _lp to lp__ as the prefix for internal parameter wrappers</title>
<updated>2012-04-16T04:32:38+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2012-04-12T07:03:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=0eacc476229e9d6c5926096b73546b5363cd9d60'/>
<id>0eacc476229e9d6c5926096b73546b5363cd9d60</id>
<content type='text'>
This will make a merge with the lib/param param code easier, as we can then paste lp_ to the front of
all parameters unconditionally.

Andrew Bartlett
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will make a merge with the lib/param param code easier, as we can then paste lp_ to the front of
all parameters unconditionally.

Andrew Bartlett
</pre>
</div>
</content>
</entry>
<entry>
<title>s3-auth Use the common auth_session_info</title>
<updated>2011-07-19T23:17:13+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2011-07-18T03:06:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=9fcc617ff5a216cc4ff1a587786522d28d84c7f2'/>
<id>9fcc617ff5a216cc4ff1a587786522d28d84c7f2</id>
<content type='text'>
This patch finally has the same structure being used to describe the
authorization data of a user across the whole codebase.

This will allow of our session handling to be accomplished with common code.

Andrew Bartlett

Signed-off-by: Andrew Tridgell &lt;tridge@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch finally has the same structure being used to describe the
authorization data of a user across the whole codebase.

This will allow of our session handling to be accomplished with common code.

Andrew Bartlett

Signed-off-by: Andrew Tridgell &lt;tridge@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s3-auth Use struct auth3_session_info outside the auth subsystem</title>
<updated>2011-07-19T23:17:10+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2011-07-15T02:45:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=f16d8f4eb86ecc4741c25e5ed87b2ea4c6717a31'/>
<id>f16d8f4eb86ecc4741c25e5ed87b2ea4c6717a31</id>
<content type='text'>
This seperation between the structure used inside the auth modules and
in the wider codebase allows for a gradual migration from struct
auth_serversupplied_info -&gt; struct auth_session_info (from auth.idl)

The idea here is that we keep a clear seperation between the structure
before and after the local groups, local user lookup and the session
key modifications have been processed, as the lack of this seperation
has caused issues in the past.

Andrew Bartlett

Signed-off-by: Andrew Tridgell &lt;tridge@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This seperation between the structure used inside the auth modules and
in the wider codebase allows for a gradual migration from struct
auth_serversupplied_info -&gt; struct auth_session_info (from auth.idl)

The idea here is that we keep a clear seperation between the structure
before and after the local groups, local user lookup and the session
key modifications have been processed, as the lack of this seperation
has caused issues in the past.

Andrew Bartlett

Signed-off-by: Andrew Tridgell &lt;tridge@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>param: Finish conversion from lp_wins_support() -&gt; lp_we_are_a_wins_server()</title>
<updated>2011-07-02T02:31:34+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2011-07-01T05:14:08+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=d4ef70a7645fb2fb21c565566c20619ff5d1a7ec'/>
<id>d4ef70a7645fb2fb21c565566c20619ff5d1a7ec</id>
<content type='text'>
Jermey started this in 1997 with 0aa493cc0303aa4177f289b9e4c797c8fa180672

(avoiding the duplicate function makes it easier to generate the
struct loadparm_globals).

Andrew Bartlett
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Jermey started this in 1997 with 0aa493cc0303aa4177f289b9e4c797c8fa180672

(avoiding the duplicate function makes it easier to generate the
struct loadparm_globals).

Andrew Bartlett
</pre>
</div>
</content>
</entry>
</feed>
