samba.git/source3/utils/net_vfs.c, branch talloc-2.3.3

net: remove NT_STATUS_STOPPED_ON_SYMLINK status code check from openat_pathref_fsp()

2021-02-05T06:22:35+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

s3:utils: Remove unused popt_common.h header from net_vfs.c

2021-01-13T20:28:34+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke

lib: give global_contexts.c its own header file

2021-01-08T20:31:33+00:00

It's a bit shocking how many references we have to global
contexts. Make this a bit more obvious.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

net: use openat_pathref_fsp() in net_vfs_get_ntacl()

2020-12-16T09:08:31+00:00

Ensures we have a pathref handle in the smb_fname we pass to
SMB_VFS_CREATE_FILE().

As the create_disposition is FILE_OPEN we just return the error if
openat_pathref_fsp() fails

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smbd: Give locking/share_mode_lock.c its own header file

2020-11-10T19:49:34+00:00

To me this is then easier to figure out what is defined there, and
where it's exactly used.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

vfs: remove dirfsp arg from SMB_VFS_CREATE_FILE()

2020-10-02T21:00:05+00:00

This was supposed to be a shortcut to avoid passing dirfsp around as an explicit
function argument throughout the whole codebase when the new VFS design idea was
based on using *AT functions throughout the VFS.

Now that we've opted for basing the VFS on handles and *AT functions will only
be used in a much more limitted extent, it makes sense to remove this internal
dirfsp reference, otherwise the combination of internal fsp->dirfsp and
smb_fname->fsp is going to be a tough to wrap your head around.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Oct  2 21:00:05 UTC 2020 on sn-devel-184

smbd: add dirfsp arg to SMB_VFS_CREATE_FILE()

2020-05-21T05:23:31+00:00

As create_file_default() still need to be updated in the future to replace the
SMB_VFS_STAT() calls with AT-based versions, it asserts (dirfsp ==
dirfsp->conn->cwd_fsp).

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

vfs: remove root_dir_fid arg from SMB_VFS_CREATE_FILE()

2020-05-14T19:43:27+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu May 14 19:43:27 UTC 2020 on sn-devel-184

smbd: add twrp arg to synthetic_smb_fname()

2020-05-05T19:18:40+00:00

Most places take twrp from a local struct smb_filename variable that the
function is working on. Some don't for various reasons:

o synthetic_smb_fname_split() is only called in very few places where we don't
  expect twrp paths

o implementations of SMB_VFS_GETWD(), SMB_VFS_FS_CAPABILITIES() and
  SMB_VFS_REALPATH() return the systems view of cwd and realpath without twrp info

o VFS modules implementing previous-versions support (vfs_ceph_snapshots,
  vfs_shadow_copy2, vfs_snapper) synthesize raw paths that are passed to VFS NEXT
  functions and therefor do not use twrp

o vfs_fruit: macOS doesn't support VSS

o vfs_recycle: in recycle_create_dir() we need a raw OS path to create a directory

o vfs_virusfilter: a few places where we need raw OS paths

o vfs_xattr_tdb: needs a raw OS path for SMB_VFS_NEXT_STAT()

o printing and rpc server: don't support VSS

o vfs_default_durable_reconnect: no Durable Handles on VSS handles, this might
  be enhances in the future. No idea if Windows supports this.

o get_real_filename_full_scan: hm.... FIXME??

o get_original_lcomp: working on a raw path

o msdfs: doesn't support VSS

o vfs_get_ntquota: synthesizes an smb_filename from ".", so doesn't support VSS
  even though VFS modules implement it

o fd_open: conn_rootdir_fname is a raw path

o msg_file_was_renamed: obvious

o open_np_file: pipes don't support VSS

o Python bindings: get's a raw path from the caller

o set_conn_connectpath: raw path

o set_conn_connectpath: raw path

o torture: gets raw paths from the caller

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

net: vfs: realign synthetic_smb_fname() args in net_vfs_get_ntacl()

2020-05-05T19:18:40+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison