samba.git/source3/utils/sharesec.c, branch master

s3: talloc_destroy() -> TALLOC_FREE()

2025-11-10T13:29:30+00:00

Sweeping change, I know. Should not change compiled code in most
cases, the compiler should be smart enough to elide the assignment
right before a return. In the cases where this is not right before the
return, TALLOC_FREE() is safer as it makes use-after-free crash.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

sharesec: Check if share exists in configuration

2025-01-10T10:45:30+00:00

Load config from registry without share info and check if sharename
exists from configuration. This results into lesser delay for the same.

In case of view we load config with all shares to ensure we get all
shares for diplay purpose.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15780

Signed-off-by: Vinit Agnihotri 
Reviewed-by: John Mulligan 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Fri Jan 10 10:45:30 UTC 2025 on atb-devel-224

sharesec: Add function to check existence of share from config

2025-01-10T09:46:32+00:00

Add function to detect if a share name exists in the registry or config file.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15780

Signed-off-by: Vinit Agnihotri 
Reviewed-by: John Mulligan 
Reviewed-by: Guenther Deschner

sharesec: Fix warning frame not freed in order

2025-01-10T09:46:32+00:00

This change should fix following warning:
Freed frame ../../source3/utils/sharesec.c:515, expected ../../source3/utils/sharesec.c:637

Frame was not getting freed in case of servicename is NULL.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15780

Signed-off-by: Vinit Agnihotri 
Reviewed-by: John Mulligan 
Reviewed-by: Guenther Deschner

s3:util:sharesec ace_compare() uses NUMERIC_CMP()

2024-04-10T22:56:33+00:00

ace->access_mask is uint32_t, so can overflow a signed int.
This would be easy to trigger, as it is a flags field rather than an
allocation count.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

s3:utils: Call gfree_all() before exit in sharesec

2023-10-25T22:23:37+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3:utils: Use lpcfg_set_cmdline() in sharesec

2023-08-23T08:27:30+00:00

Signed-off-by: Pavel Kalugin 
Reviewed-by: Andreas Schneider

sharesec: don't ignore unknown options

2021-09-10T15:10:30+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

s3:utils: Migrate sharesec to new cmdline option parser

2021-05-25T00:23:37+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3:utils: Remove '-V' for '--viewsddl' from sharesec

2021-05-25T00:23:37+00:00

The '-V' is already used for '-V|--version' in the common options.

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett