samba.git/source3/utils, branch master

s3/rpc_server: Add worker status smbcontrol message support

2026-04-14T12:12:07+00:00

Add information about the number of connections a rpc_worker
process is handling and when each connection was initiated.

command
  smbcontrol 55063 rpc-dump-worker-status

will output data like below:

  rpcd_spoolss pid 55063:
      num connections = 2
      num_association_groups = 2
      last client connection 2026/03/18 06:51:04.482192
      last client disconnection 2026/03/18 06:51:00.304951
   active connections:
      [1] endpoint=ncacn_np:[\pipe\spoolss] client addr=192.168.32.175 server=priu0002 connected at 2026/03/18 06:51:04.482192
      [2] endpoint=ncacn_np:[\pipe\spoolss] client addr=192.168.33.232 server=priu0002 connected at 2026/03/18 06:47:08.466157

Signed-off-by: Noel Power 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Tue Apr 14 12:12:07 UTC 2026 on atb-devel-224

net: Use create_conn_struct_chdir() in "net vfs"

2026-03-01T20:19:35+00:00

We don't need to jump back to the previous cwd when exiting from the
net vfs process.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

s3:utils: Fix misleading recursive flag in smbget error message

2026-02-16T15:37:04+00:00

The error message in smbget incorrectly instructs users to use "-R" for
recursive downloads.

In recent Samba versions, the "-R" flag was repurposed for
"--name-resolve" to align with other tools. The correct flag for
recursion is now "--recursive". This mismatch causes confusion as using
"-R" triggers a parameter parsing error rather than enabling recursion.

This patch updates the error string to correctly suggest "--recursive"
instead of "-R".

RN: smbget: Fix error message suggesting wrong flag for recursion.

Signed-off-by: Hugo Chia hugochiaxyz.nus@gmail.com
Reviewed-by: Anoop C S 
Reviewed-by: John Mulligan 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Mon Feb 16 15:37:04 UTC 2026 on atb-devel-224

s3:utils: 'net ads kerberos kinit' should use also default ccache name from krb5.conf

2026-02-05T19:59:36+00:00

This is re-introducing the behavior from samba-4.20 where both these
commands operated on the same ccache (default_ccache_name in
[libdefaults] section of krb5.conf)

 'net ads kerberos kinit -P'
 'klist'

 With samba-4.21 it no longer works, 'net ads kerberos kinit -P'
 fallbacks to 'MEMORY:net' (which is of a very limited use, ticket
 cannot be used by other process) and klist finds no ticket.

 The order is changed from:

    --use-krb5-ccache
    env "KRB5CCNAME"
    "MEMORY:net"

to ("MEMORY:net" is removed):

    --use-krb5-ccache
    env "KRB5CCNAME"
    default_ccache_name

'--use-krb5-ccache=MEMORY:net' can be used to validate the credentials.

Use smb_force_krb5_cc_default_name() instead of krb5_cc_default_name()
because of commit:
1ca6fb5 make sure krb5_cc_default[_name]() is no longer used directly

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:utils:status_json fix Non-boolean returned

2026-01-15T09:18:21+00:00

Fix cppcheck

source3/utils/status_json.c:1385:3: style: Non-boolean value returned
    from function returning bool [returnNonBoolInBooleanFunction]

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15924

Signed-off-by: Gary Lockyer 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Anoop C S 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Thu Jan 15 09:18:21 UTC 2026 on atb-devel-224

lib: Remove unnecessary assignments

2026-01-07T09:57:40+00:00

data_blob_free() already NULLs out its argument

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

lib: Don't call a function to initialize an empty DATA_BLOB

2026-01-07T09:57:40+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

s3-net: properly setup krb5 ccache name via --use-krb5-ccache

2026-01-05T14:35:43+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15840

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider

s3:testparm: Fix "sync machine password to keytab" validation

2025-12-23T09:43:56+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Pavel Filipenský 

Autobuild-User(master): Samuel Cabrero 
Autobuild-Date(master): Tue Dec 23 09:43:56 UTC 2025 on atb-devel-224

net/serverid: initialize state->open_db

2025-11-27T09:01:29+00:00

Fixes a crash that happens when smbXsrv_open_global.tdb contains only replay
records.

  #0  0x00007ffff70a718a in dbwrap_exists (db=0x0, key=...) at ../../lib/dbwrap/dbwrap.c:347
  #1  0x00000000002dc7f2 in wipedbs_traverse_replay_records (rec=0x7fffffffd180, wipedbs_state=0x362d70)
      at ../../source3/utils/net_serverid.c:710
  #2  0x00007ffff70aa932 in db_rbt_traverse_internal (db=0x37e940, f=0x2dc749 , private_data=0x362d70,
      count=0x7fffffffd220, rw=false) at ../../lib/dbwrap/dbwrap_rbt.c:472
  #3  0x00007ffff70aaa0e in db_rbt_traverse_read (db=0x37e940, f=0x2dc749 , private_data=0x362d70)
      at ../../lib/dbwrap/dbwrap_rbt.c:499
  #4  0x00007ffff70a7433 in dbwrap_traverse_read (db=0x37e940, f=0x2dc749 , private_data=0x362d70, count=0x0)
      at ../../lib/dbwrap/dbwrap.c:437
  #5  0x00000000002dcedf in net_serverid_wipedbs (c=0x34c0d0, argc=0, argv=0x365380) at ../../source3/utils/net_serverid.c:840
  #6  0x00000000002c9675 in net_run_function (c=0x34c0d0, argc=1, argv=0x365378, whoami=0x258c96 "net tdb smbXsrv", table=0x7fffffffd360)
      at ../../source3/utils/net_util.c:451
  #7  0x00000000002e6e2c in net_tdb_smbXsrv (c=0x34c0d0, argc=1, argv=0x365378) at ../../source3/utils/net_tdb.c:105
  #8  0x00000000002c9675 in net_run_function (c=0x34c0d0, argc=2, argv=0x365370, whoami=0x258d45 "net tdb", table=0x7fffffffd440)
      at ../../source3/utils/net_util.c:451
  #9  0x00000000002e6f04 in net_tdb (c=0x34c0d0, argc=2, argv=0x365370) at ../../source3/utils/net_tdb.c:128
  #10 0x00000000002c9675 in net_run_function (c=0x34c0d0, argc=3, argv=0x365368, whoami=0x22ca4b "net", table=0x323640 )
      at ../../source3/utils/net_util.c:451
  #11 0x0000000000277227 in main (argc=6, argv=0x7fffffffe2a8)
      at ../../source3/utils/net.c:1481

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke