samba.git/source3/utils, branch talloc-2.1.2

s3:smbprofile: Replace sysv shmem with tdb

2015-03-06T11:31:10+00:00

What?

This patch gets rid of the central shared memory segment referenced by
"profile_p". Instead, every smbd gets a static profile_area where it collects
profiling data. Once a second, every smbd writes this profiling data into a
record of its own in a "smbprofile.tdb". smbstatus -P does a tdb_traverse on this
database and sums up what it finds.

Why?

At least in my perception sysv IPC has not the best reputation on earth. The
code before this patch uses shmat(). Samba ages ago has developed a good
abstraction of shared memory: It's called tdb.

The main reason why I started this is that I have a request to become
more flexible with profiling data. Samba should be able to collect data
per share or per user, something which is almost impossible to do with
a fixed structure. My idea is to for example install a profile area per
share and every second marshall this into one tdb record indexed by share
name. smbstatus -P would then also collect the data and either aggregate
them or put them into individual per-share statistics. This flexibility
in the data model is not really possible with one fixed structure.

But isn't it slow?

Well, I don't think so. I can't really prove it, but I do believe that on large
boxes atomically incrementing a shared memory value for every SMB does show up
due to NUMA effects. With this patch the hot code path is completely
process-local. Once a second every smbd writes into a central tdb, this of
course does atomic operations. But it's once a second, not on every SMB2 read.

There's two places where I would like to improve things: With the current code
all smbds wake up once a second. With 10,000 potentially idle smbds this will
become noticable. That's why the current only starts the timer when something has
changed.

The second place is the tdb traverse: Right now traverse is blocking in the
sense that when it has to switch hash chains it will block. With mutexes, this
means a syscall. I have a traverse light in mind that works as follows: It
assumes a locked hash chain and then walks the complete chain in one run
without unlocking in between. This way the caller can do nonblocking locks in
the first round and only do blocking locks in a second round. Also, a lot of
syscall overhead will vanish. This way smbstatus -P will have almost zero
impact on normal operations.

Pair-Programmed-With: Stefan Metzmacher 

Signed-off-by: Volker Lendecke 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3:smbprofile: specify SMBPROFILE_STATS_SECTION_START() with name vs. display[name]

2015-03-06T11:31:10+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

Fix the O3 developer build

2015-03-03T12:14:53+00:00

Different gcc versions complain at different places

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Mar  3 13:14:53 CET 2015 on sn-devel-104

Fix the developer O3 build

2015-02-25T15:32:29+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Alexander Bokovoy 
Autobuild-Date(master): Wed Feb 25 16:32:29 CET 2015 on sn-devel-104

nmblookup: Warn user if netbios name is too long.

2015-02-24T00:01:10+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Feb 24 01:01:10 CET 2015 on sn-devel-104

regedit: Rename variable to fix compile warning

2015-02-19T00:31:43+00:00

With --picky-developer this warning is turned into an error:

cc1: warnings being treated as errors
../source3/utils/regedit_treeview.c: In function ‘tree_node_load_children’:
../source3/utils/regedit_treeview.c:256: error: declaration of ‘key_name’ shadows a global declaration
/usr/include/ncurses.h:1419: error: shadowed declaration is here

Fix this by renaming the local variable.

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Feb 19 01:31:44 CET 2015 on sn-devel-104

utils: Fix 'net time' segfault.

2015-01-19T05:48:05+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11058

This is part two of the bugfix. Make sure we pass the IP we found to
cli_servertime(). Hence we always pass at least one of name or IP.

Pair-Programmed-With: Michael Adam 

Signed-off-by: Andreas Schneider 
Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison

net: Fix sam addgroupmem

2015-01-13T14:28:16+00:00

Domain local groups come across as SID_TYPE_ALIAS and are sent to us in the
PAC/Info3 struct. We should allow this in net sam addgroupmem.

Volker

Signed-off-by: Volker Lendecke 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Tue Jan 13 15:28:16 CET 2015 on sn-devel-104

allow net ads join accept new osServicePack parameter

2015-01-07T23:18:05+00:00

osServicePack paramater allows the default behaviour ( which is to use
the samba version string as the operatingSystemServicePack attribute )
to be overridden
Additionally make sure if blank string is passed that it is treated
as attribute deletion. This is necessary as values for the os attributes
are eventually passed to ads_modlist_add if the value is "" then the
attempt to add this attribute fails in the underlying ldap
'ldap_modfiy_ext_s' function. In this case we need to pass NULL as the
value to force deletion of the ldap attribute

Signed-off-by: Noel Power 
Reviewed-by: David Disseldorp 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Jan  8 00:18:05 CET 2015 on sn-devel-104

addns: Remove support for dns_host_file.

2014-12-18T05:47:40+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett