samba.git/source3/utils, branch talloc-2.3.1

s3:printing: Fix %J substition

2019-11-07T16:01:21+00:00

print_run_command() uses lp_print_command() which internally performs basic
substition by calling talloc_sub_basic(). As a result. any of the variables in
the "basic set", including "%J" are already substituted.

To prevent the unwanted subtitution, we declare all affected configuration
options as const, which disabled the basic substition.

As a result print_run_command() can run manual substitution on all characters,
including %J, in the variadic argument list *before* calling lp_string() to run
basic substition which we had disabled before with the const.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745

Signed-off-by: Ralph Boehme 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu Nov  7 16:01:21 UTC 2019 on sn-devel-184

ntlm_auth: Fix nonempty line endings

2019-11-06T20:36:35+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

ntlm_auth: Simplify session generation

2019-11-06T20:36:34+00:00

We don't need to parse a text sid, we have those as binary available

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

net: Avoid the use of g_lock_do()

2019-11-06T20:36:34+00:00

g_lock_do() does too much in g_lock.c, and it's rarely used.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

net: Avoid the use of g_lock_do()

2019-11-06T20:36:34+00:00

g_lock_do() does too much in g_lock.c, and it's rarely used.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Remove #define serverid_equal server_id_equal

2019-11-06T20:36:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

source3/utils/net_rpc.c: typo fixes

2019-10-31T00:43:37+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Martin Schwenke

s3: utils: smbtree. Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.

2019-10-30T20:44:31+00:00

Last unprotected call of cli_RNetShareEnum(). Not a libsmbclient
bug here but might as well fix the last caller as part of the
fix for the bug.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

s3: remove now unneeded call to cmdline_messaging_context()

2019-10-24T09:33:47+00:00

This was only needed as dbwrap_open() had a bug where it asked for the ctdb
connection before initializing messaging. The previous commit fixed that so we
can now safely remove the calls to cmdline_messaging_context() from all tools
that don't use messaging.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Oct 24 09:33:47 UTC 2019 on sn-devel-184

net: 'net ads gpo getgpo' command not dumping gpo

2019-10-22T19:39:40+00:00

We have passed dump_gpo(debuglevel=1), hence gpo is not
dumped at debuglevel=0. But end user will expect gpo
to be dumped without setting debug flag.

Signed-off-by: Amit Kumar 
Reviewed-by: Ralph Boehme 
Reviewed-by: Noel Power