samba.git/source3/utils, branch talloc-2.3.4

s3/util/py_net.c: fix samba-tool domain join&leave segfault

2022-05-25T06:19:32+00:00

We process python args using PyArg_ParseTupleAndKeywords(), and use "p"
type modifier there.  According to documentation, this type modifier,
while works for a boolean type, expects an argument of type int. But in
py_net_join_member() and  py_net_leave() we use argument of type uint8_t
(no_dns_update, keep_account, r->in.debug). So when PyArg_ParseTupleAndKeywords()
tries to assign a value to &no_dns_update, it updates subsequent, unrelated bytes
too, - which ones depends on the stack and structure layout used by the compiler.

Fix this by using int type for all relevant variables, and by introducing proxy
variable "debug" (of the same type) for r->in.debug.

While at it, also ensure all variables have sensible default values.

Signed-off-by: Michael Tokarev 
Reviewed-by: Alexander Bokovoy 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed May 25 06:19:32 UTC 2022 on sn-devel-184

Revert "vfs: remove dirfsp arg from SMB_VFS_CREATE_FILE()"

2022-04-28T13:12:33+00:00

This reverts commit 322574834f1e71bc01f21be9059ca4d386517c84.

Not strictly a revert anymore, but for future work we do need "dirfsp"
in create_file_default() passed through the VFS.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

s3:utils:smbcacls fix a typo

2022-04-21T06:03:38+00:00

Signed-off-by: Christian Ambach 
Reviewed-by: Volker Lendecke 
Reviewed-by: Christof Schmitt

s3: smbget: Fix auth_fn, order of //server/share parameters is mixed in prompt.

2022-04-06T16:15:36+00:00

Found by 

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14831

Signed-off-by: Jeremy Allison 
Reviewed-by: Andreas Schneider

ntlm_auth: Adapt --diagnostics mode to expect that the DC does not support LANMAN by default

2022-03-17T01:57:38+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Stefan Metzmacher

s3-ntlm_auth: Convert table of tests in --diagnostics to designated initialisers

2022-03-17T01:57:38+00:00

This makes it easeir to set some as "LM auth".

Signed-off-by: Andrew Bartlett 
Reviewed-by: Stefan Metzmacher

s3:utils: assign ids to struct to list shares correctly

2022-03-07T15:27:48+00:00

The commit "99d1f1fa10d smbd: Remove unused "struct connections_key"" removes
also the assignment of information to connections_data, which are needed to list
shares.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14999

Signed-off-by: Jule Anger 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Jule Anger 
Autobuild-Date(master): Mon Mar  7 15:27:48 UTC 2022 on sn-devel-184

s3:libads: Return canonical principal and realm from kerberos_return_pac()

2022-02-23T15:20:32+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14979

Signed-off-by: Samuel Cabrero 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

s3:py_net: allow machinepass=None to py_net_join_member()

2022-02-23T07:50:38+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14984

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

s3:utils: Fix missing space in testparm output

2022-02-21T15:03:24+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Mon Feb 21 15:03:24 UTC 2022 on sn-devel-184