samba.git/source3/winbindd/wb_queryuser.c, branch talloc-2.4.4

idmap_ad: add and use ldap_timeout and fix LDAP server failover

2025-08-13T18:30:44+00:00

The key parts are:

1. If an LDAP search fails with the hardcoded fatal error, remove the
retry. That would only retry the query against the same server, taken
from the DCINFO cache key. Instead, force a DC rediscovery.

2. Set a default ldap_timeout and pass it to tldap_search(). This
avoids tldap_search() hanging forever on a stale TCP connection.

3. The LDAP server idmap_ad is using is not necessarily the same DC
we're using for RPC, so in case we learn about a dead DC, put it in
the negative-conn-cache.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15844

Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner

s3-winbindd: Fix internal winbind dsgetdcname calls w.r.t. domain name

2025-07-07T10:44:37+00:00

when winbind calls to dsgetdcname internally, make sure to
prefer the DNS domain name if we have it. Makes DNS lookups much more
likely to succeed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15876

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Jul  7 10:44:37 UTC 2025 on atb-devel-224

s4:torture: Skip test_membership_user for users that get incorrectly assigned group sid

2023-06-13T12:15:32+00:00

This commit should be removed once wb_queryuser() is fixed.

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:winbind: Fix the default group for the 'Guest' user

2023-06-13T12:15:32+00:00

If samlogon cache has no entry for the 'Guest' user, the group sid
should default to 'Guests' group.

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:winbind: Change '%u' to '%PRIu32' for uint32_t in wb_queryuser.c

2022-07-21T13:47:31+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

s3:winbind: Improve logging in wb_queryuser.c

2022-07-15T14:25:38+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider

winbindd: call wb_parent_idmap_setup_send() in wb_queryuser_send()

2021-09-02T14:29:35+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14804

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

wb_queryuser: explain why wb_parent_idmap_setup_send/recv is not needed

2020-10-23T03:25:36+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14539

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer

wb_queryuser: avoid idmap_child() and use idmap_child_handle() instead

2020-10-23T03:25:35+00:00

This is the only aspect we need here.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14539

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer

winbind: provide passwd struct for group sid with ID_TYPE_BOTH mapping (again)

2019-09-27T17:25:29+00:00

https://git.samba.org/?p=samba.git;a=commitdiff;h=394622ef8c916cf361f8596dba4664dc8d6bfc9e
originally introduced the above feature.

This functionality was undone as part of "winbind: Restructure get_pwsid"
https://git.samba.org/?p=samba.git;a=commitdiff;h=bce19a6efe11980933531f0349c8f5212419366a
I think that this semantic change was accidential.

This patch undoes the semantic change and re-establishes the
functionality.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14141

Signed-off-by: Michael Adam 
Reviewed-by: Christof Schmitt 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Christof Schmitt 
Autobuild-Date(master): Fri Sep 27 17:25:29 UTC 2019 on sn-devel-184