samba.git/source3/winbindd/winbindd_cache.c, branch talloc-2.3.0 Unnamed repository; edit this file 'description' to name the repository. s3/winbdind: cppcheck: fix nullPointerArithmetic error 2019-06-04T22:13:07+00:00 Noel Power noel.power@suse.com 2019-05-22T14:17:48+00:00 edbef9e0403482a66243d3aa8752804fa1666e43 Fixes source3/winbindd/winbindd_cache.c:4386: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck] source3/winbindd/winbindd_cache.c:4400: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck] source3/winbindd/winbindd_cache.c:1569:24: warning: Dereference of null pointer <--[clang] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org> 
Fixes

source3/winbindd/winbindd_cache.c:4386: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:4400: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:1569:24: warning: Dereference of null pointer <--[clang]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
winbind: Use domain name from lsa query for sid_to_name cache entry 2019-04-18T17:21:18+00:00 Christof Schmitt cs@samba.org 2019-03-11T23:14:02+00:00 aec9bda25f10ca2710d91fb680cca7904e92f9de When winbindd is asked to map a name like realm.com\name to a SID ,that is sucessfully resolved through the lsa lookup name call. The same call also returns the short domain name (netbios name of the domain). Use that short domain name for the sid_to_name cache entry, so that subsequent sid_to_name queries return the expected netbiosname\name result and not realm.com\name. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> 
When winbindd is asked to map a name like realm.com\name to a SID ,that
is sucessfully resolved through the lsa lookup name call. The same call
also returns the short domain name (netbios name of the domain). Use
that short domain name for the sid_to_name cache entry, so that
subsequent sid_to_name queries return the expected netbiosname\name
result and not realm.com\name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
winbind: Return queried domain name from name_to_sid 2019-04-18T17:21:18+00:00 Christof Schmitt cs@samba.org 2019-03-11T23:11:01+00:00 640e0ef4fd338ddf03b813a8d45cce67c7ec7a01 BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
winbindd: Use dom_sid_str_buf 2018-12-20T22:40:25+00:00 Volker Lendecke vl@samba.org 2018-12-14T20:09:51+00:00 58f76ab13760947ddf2e8298e8191fa084105a7f Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
winbindd_cache: Use dom_sid_str_buf 2018-12-07T22:29:00+00:00 Volker Lendecke vl@samba.org 2018-12-06T17:25:02+00:00 263edf7fe96ab7b072bd3733074e44e6ab60a80b Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbind: Use dom_sid_str_buf 2018-11-09T21:42:28+00:00 Volker Lendecke vl@samba.org 2018-10-27T20:01:03+00:00 58e77b542257342139069210092ae92e8f153680 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbind: Use dom_sid_str_buf 2018-11-09T21:42:28+00:00 Volker Lendecke vl@samba.org 2018-10-26T06:25:14+00:00 21bfc7743970f985ffef1b558120203c76739ec3 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
s3: winbind: Remove fstring from wb_acct_info struct 2018-11-01T00:59:10+00:00 Samuel Cabrero scabrero@suse.de 2018-10-30T17:47:16+00:00 8d14714cc5e4c2b439e973faf602afb2fc1e7488 The group enumeration backend functions try to allocate an array of wb_acct_info structs with a number of elements equal to the number of groups. In domains with a large number of groups this allocation may fail due to the size of the chunk. Found while trying to enumerate the groups in a domain with more than 700k groups. Signed-off-by: Samuel Cabrero <scabrero@suse.de> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
The group enumeration backend functions try to allocate an array of
wb_acct_info structs with a number of elements equal to the number of
groups. In domains with a large number of groups this allocation may
fail due to the size of the chunk.

Found while trying to enumerate the groups in a domain with more than
700k groups.

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
namemap_cache: Absorb the expired calculation into namemap_cache.c 2018-10-16T16:00:10+00:00 Volker Lendecke vl@samba.org 2018-10-13T10:01:41+00:00 fdb50817cac2423adae3daf94759ecf1e6580760 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbindd_cache: Fix timeout calculation for sid<->name cache 2018-10-16T16:00:10+00:00 Volker Lendecke vl@samba.org 2018-10-13T09:39:03+00:00 fb573c682353daf5b343b6a0f4832dcbc96ebc57 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>