samba.git/source3/winbindd/winbindd_cache.c, branch talloc-2.3.2 Unnamed repository; edit this file 'description' to name the repository. s3: safe_string: do not include string_wrappers.h 2020-08-28T00:56:34+00:00 Matthew DeVore matvore@google.com 2020-08-07T18:17:34+00:00 c2ac923c6a5d089fe110eb3eb6cf78298b46992d Rather than have safe_string.h #include string_wrappers.h, make users of string_wrappers.h include it explicitly. includes.h now no longer includes string_wrappers.h transitively. Still allow includes.h to #include safe_string.h for now so that as many modules as possible get the safety checks in it. Signed-off-by: Matthew DeVore <matvore@google.com> Reviewed-by: David Mulder <dmulder@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Rather than have safe_string.h #include string_wrappers.h, make users of
string_wrappers.h include it explicitly.

includes.h now no longer includes string_wrappers.h transitively. Still
allow includes.h to #include safe_string.h for now so that as many
modules as possible get the safety checks in it.

Signed-off-by: Matthew DeVore <matvore@google.com>
Reviewed-by: David Mulder <dmulder@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbind: Use vasprintf() in winbindd_cache 2019-12-02T21:23:35+00:00 Volker Lendecke vl@samba.org 2019-11-27T18:00:26+00:00 6d1ce7dc1723e0c9f63b6b5ec08141f198049a56 Don't need to panic, we can do explicit checks in these few callers Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martins@samba.org> 
Don't need to panic, we can do explicit checks in these few callers

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martins@samba.org>
winbind: Fix CID 1455915 Resource leak 2019-11-19T16:13:36+00:00 Volker Lendecke vl@samba.org 2019-11-19T13:20:14+00:00 b9e74928ab99a169c76dcd3b401da70cbd1b3985 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
s3:winbindd: Replace E_md5hash() with GnuTLS calls 2019-11-19T04:48:29+00:00 Andreas Schneider asn@samba.org 2019-11-18T09:24:56+00:00 10499507c4fd91751898696b866ce32b1e38f605 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s3/winbdind: cppcheck: fix nullPointerArithmetic error 2019-06-04T22:13:07+00:00 Noel Power noel.power@suse.com 2019-05-22T14:17:48+00:00 edbef9e0403482a66243d3aa8752804fa1666e43 Fixes source3/winbindd/winbindd_cache.c:4386: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck] source3/winbindd/winbindd_cache.c:4400: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck] source3/winbindd/winbindd_cache.c:1569:24: warning: Dereference of null pointer <--[clang] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org> 
Fixes

source3/winbindd/winbindd_cache.c:4386: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:4400: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:1569:24: warning: Dereference of null pointer <--[clang]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
winbind: Use domain name from lsa query for sid_to_name cache entry 2019-04-18T17:21:18+00:00 Christof Schmitt cs@samba.org 2019-03-11T23:14:02+00:00 aec9bda25f10ca2710d91fb680cca7904e92f9de When winbindd is asked to map a name like realm.com\name to a SID ,that is sucessfully resolved through the lsa lookup name call. The same call also returns the short domain name (netbios name of the domain). Use that short domain name for the sid_to_name cache entry, so that subsequent sid_to_name queries return the expected netbiosname\name result and not realm.com\name. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> 
When winbindd is asked to map a name like realm.com\name to a SID ,that
is sucessfully resolved through the lsa lookup name call. The same call
also returns the short domain name (netbios name of the domain). Use
that short domain name for the sid_to_name cache entry, so that
subsequent sid_to_name queries return the expected netbiosname\name
result and not realm.com\name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
winbind: Return queried domain name from name_to_sid 2019-04-18T17:21:18+00:00 Christof Schmitt cs@samba.org 2019-03-11T23:11:01+00:00 640e0ef4fd338ddf03b813a8d45cce67c7ec7a01 BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
winbindd: Use dom_sid_str_buf 2018-12-20T22:40:25+00:00 Volker Lendecke vl@samba.org 2018-12-14T20:09:51+00:00 58f76ab13760947ddf2e8298e8191fa084105a7f Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
winbindd_cache: Use dom_sid_str_buf 2018-12-07T22:29:00+00:00 Volker Lendecke vl@samba.org 2018-12-06T17:25:02+00:00 263edf7fe96ab7b072bd3733074e44e6ab60a80b Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbind: Use dom_sid_str_buf 2018-11-09T21:42:28+00:00 Volker Lendecke vl@samba.org 2018-10-27T20:01:03+00:00 58e77b542257342139069210092ae92e8f153680 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>