samba.git/source3/winbindd/winbindd_cache.c, branch talloc-2.3.3

s3:winbind: Code cleanup for initialize_winbindd_cache()

2021-05-12T20:29:32+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3:winbind: Remove global variable for winbindd_offline_state

2021-05-12T20:29:32+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3:winbindd: Simplfy sequence number caching

2021-04-29T15:01:29+00:00

The sequence number is used to detect if the cache is still valid. It
expires when the `winbind cache time` is over. After that time we want
to fetch new information from a DC to make sure we are up to date.

If a DC goes down and we recreate the connection, we want to expire the
caches sooner. So we reset the sequence number and the next call should
refill the caches.

Using the current time as the sequence number is more reliable, as the
sequence number of two DCs could in theory be equal. All we have to do
is to make sure we reset it after we reconnect to a DC.

Previously the sequence number check was based on the AD database change
sequence number. Now this is based on a current time value which gets
reset after a successful (re)connect.

Pair-Programmed-With: Stefan Metzmacher 
Signed-off-by: Andreas Schneider 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3: safe_string: do not include string_wrappers.h

2020-08-28T00:56:34+00:00

Rather than have safe_string.h #include string_wrappers.h, make users of
string_wrappers.h include it explicitly.

includes.h now no longer includes string_wrappers.h transitively. Still
allow includes.h to #include safe_string.h for now so that as many
modules as possible get the safety checks in it.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison

winbind: Use vasprintf() in winbindd_cache

2019-12-02T21:23:35+00:00

Don't need to panic, we can do explicit checks in these few callers

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

winbind: Fix CID 1455915 Resource leak

2019-11-19T16:13:36+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

s3:winbindd: Replace E_md5hash() with GnuTLS calls

2019-11-19T04:48:29+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3/winbdind: cppcheck: fix nullPointerArithmetic error

2019-06-04T22:13:07+00:00

Fixes

source3/winbindd/winbindd_cache.c:4386: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:4400: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:1569:24: warning: Dereference of null pointer <--[clang]

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

winbind: Use domain name from lsa query for sid_to_name cache entry

2019-04-18T17:21:18+00:00

When winbindd is asked to map a name like realm.com\name to a SID ,that
is sucessfully resolved through the lsa lookup name call. The same call
also returns the short domain name (netbios name of the domain). Use
that short domain name for the sid_to_name cache entry, so that
subsequent sid_to_name queries return the expected netbiosname\name
result and not realm.com\name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt 
Reviewed-by: Volker Lendecke

winbind: Return queried domain name from name_to_sid

2019-04-18T17:21:18+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt 
Reviewed-by: Volker Lendecke