samba.git/source3/winbindd/winbindd_cache.c, branch talloc-2.3.4

s3:winbind: Move function to flush cache to winbindd-lib subsystem

2022-04-08T20:13:37+00:00

The source3/winbindd/winbindd.c file does not belong to 'winbindd-lib'
subsystem. Funtions called from winbindd-lib must be part of it.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison

s3:winbind: Move functions to enable or disable cache to winbindd-lib subsystem

2022-04-08T20:13:37+00:00

The source3/winbindd/winbindd.c file does not belong to 'winbindd-lib'
subsystem. Funtions called from winbindd-lib must be part of it.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison

s3:winbind: Convert wcache_opnum_cacheable() to a whitelist

2022-03-25T17:03:29+00:00

It avoids having to explicitly blacklist new DCE/RPC calls.

This is the current list of non cacheable calls:

NDR_WBINT_PING
NDR_WBINT_QUERYSEQUENCENUMBER
NDR_WBINT_ALLOCATEUID
NDR_WBINT_ALLOCATEGID
NDR_WBINT_CHECKMACHINEACCOUNT
NDR_WBINT_CHANGEMACHINEACCOUNT
NDR_WBINT_PINGDC
NDR_WBINT_LISTTRUSTEDDOMAINS

It includes the ListTrustedDomains call recently converted to a local
RPC call.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Stefan Metzmacher

s3:winbind: Reduce the level and improve a couple of debug messages

2022-02-09T20:20:36+00:00

The commit 1d5c546 changed the debug message printed when setting
winbind to offline state and offline logons are disabled from
level 10 to level 0. This message isn't really an error and might
scare some users, e.g. https://bugzilla.suse.com/show_bug.cgi?id=1195573

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Feb  9 20:20:36 UTC 2022 on sn-devel-184

s3:winbind: Code cleanup for initialize_winbindd_cache()

2021-05-12T20:29:32+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3:winbind: Remove global variable for winbindd_offline_state

2021-05-12T20:29:32+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3:winbindd: Simplfy sequence number caching

2021-04-29T15:01:29+00:00

The sequence number is used to detect if the cache is still valid. It
expires when the `winbind cache time` is over. After that time we want
to fetch new information from a DC to make sure we are up to date.

If a DC goes down and we recreate the connection, we want to expire the
caches sooner. So we reset the sequence number and the next call should
refill the caches.

Using the current time as the sequence number is more reliable, as the
sequence number of two DCs could in theory be equal. All we have to do
is to make sure we reset it after we reconnect to a DC.

Previously the sequence number check was based on the AD database change
sequence number. Now this is based on a current time value which gets
reset after a successful (re)connect.

Pair-Programmed-With: Stefan Metzmacher 
Signed-off-by: Andreas Schneider 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3: safe_string: do not include string_wrappers.h

2020-08-28T00:56:34+00:00

Rather than have safe_string.h #include string_wrappers.h, make users of
string_wrappers.h include it explicitly.

includes.h now no longer includes string_wrappers.h transitively. Still
allow includes.h to #include safe_string.h for now so that as many
modules as possible get the safety checks in it.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison

winbind: Use vasprintf() in winbindd_cache

2019-12-02T21:23:35+00:00

Don't need to panic, we can do explicit checks in these few callers

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

winbind: Fix CID 1455915 Resource leak

2019-11-19T16:13:36+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider