samba.git/source3/winbindd/winbindd_cm.c, branch talloc-2.4.0

winbindd: Add force_dc to bypass cached connection and DC lookup

2022-12-21T19:10:35+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

winbindd: More simplification of cm_open_connection()

2022-12-21T19:10:35+00:00

This basically moves the functionality to connect the socket to the currently
preferred DC to a new helper function connect_preferred_dc() that is called from
the renamed function find_new_dc().

find_dc() now either returns a connected to the preferred DC or a new DC until
all possible DCs are exhausted and cm_open_connection() can just call find_dc()
to get a connected socket and pass it to cm_prepare_connection().

While at it reorder the args of find_dc() and make the only real out arg "fd"
the last one.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

winbindd: simplify cm_open_connection()

2022-12-21T19:10:35+00:00

Simplify to retry logic: if cm_prepare_connection() succeeded just exit the
retry loop, only if it failed check the "retry" variable.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

winbindd: simplify find_new_dc()

2022-12-21T19:10:35+00:00

Remove the dcname and pss args from find_new_dc(). The caller passes in the
domain anyway, so let's fill in domain->dcname and domain->dcaddr directly.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

winbindd: do an early exit in cm_open_connection()

2022-12-21T19:10:35+00:00

Best viewed with git show -w. No change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

CVE-2022-38023 s3:winbindd: also allow per domain "winbind sealed pipes:DOMAIN" and "require strong key:DOMAIN"

2022-12-13T13:07:29+00:00

This avoids advising insecure defaults for the global options.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15240

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Ralph Boehme

s3: winbind: Add missing NULL check for returned talloc'ed ADS struct.

2022-06-30T15:35:32+00:00

Coverity CID: 1506720.

Signed-off-by: Jeremy Allison 
Reviewed-by: Andreas Schneider

s3:libads: Allocate ADS_STRUCT under a talloc context

2022-06-27T15:50:30+00:00

The ads_destroy() function is now static and only called from the
ADS_STRUCT destructor.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison

s3:winbind: Allocate a temporary memory context for dcip_check_name_ads()

2022-06-27T15:50:29+00:00

Prepare to allocate ADS_STRUCT under a talloc context.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison

s3:winbind: Early return on error in dcip_check_name_ads()

2022-06-27T15:50:29+00:00

Also use new debug macros and improve debug message.

Best viewed with "git diff -b".

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison