samba.git/source3/winbindd/winbindd_idmap.c, branch talloc-2.4.4

winbindd: let LookupNames return NT_STATUS_OK and SID_NAME_UNKNOWN for unmapped names

2024-07-26T10:06:31+00:00

Previously LookupNames would fail if a name could not be translated, so winbindd
clients like libwbclient couldn't differentiate between not being able to talk
to a DC and just an unkown name.

As a visible change this alters

  $ bin/wbinfo -n Idontexist
  failed to call wbcLookupName: WBC_ERR_DOMAIN_NOT_FOUND
  Could not lookup name Idontexist

to

  $ bin/wbinfo -n Idontexist
  failed to call wbcLookupName: WBC_ERR_SOME_NOT_MAPPED
  Could not lookup name Idontexist

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

s3:winbind: talloc the static idmap child

2023-12-13T15:07:38+00:00

Next commits will use talloc_get_type_abort() to get the reference.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Alexander Bokovoy

s3:winbind: Avoid unnecessary locking in wb_parent_idmap_setup_send()

2022-11-04T10:06:28+00:00

A function in tevent environment can span over several context loop iterations.
Every iteration 'unschedules' the current code and a different functions can
access not yet fully initialized structures.

A locking is used to avoid this. In tevent, we use tevent queues as a locking
mechanism. Every function trying to access lock protected data, puts itself to
a queue. The function must remove itself from the queue only after the complete
work is done.

A good coding practise is to lock only the smallest code path and not to use the
locking if not needed.

wb_parent_idmap_setup_send() uses queue "wb_parent_idmap_config_queue" for:
- testing if the setup is ready
- setting up all idmap domains

But "testing if the setup is ready" can be coded as an atomic operation without
needing a lock.

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Nov  4 10:06:28 UTC 2022 on sn-devel-184

s3:winbind: Remove struct winbindd_child_dispatch_table

2022-05-19T18:50:24+00:00

All parent-child communication is based in NDR and dispatched as a local
RPC call.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu May 19 18:50:24 UTC 2022 on sn-devel-184

s3:winbind: Convert Ping parent/child call to NDR

2022-03-25T17:03:29+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Stefan Metzmacher

lib: give global_contexts.c its own header file

2021-01-08T20:31:33+00:00

It's a bit shocking how many references we have to global
contexts. Make this a bit more obvious.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

winbindd: defer the setup_child() from init_idmap_child()

2020-10-23T03:25:36+00:00

At startup we trigger a wb_parent_idmap_setup_send() and make
sure setup_child() is called just before wb_parent_idmap_setup_recv()
finished.

This makes sure our view of the idmap config in the parent matches
what we have in the child.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14539

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer

winbindd: assert wb_parent_idmap_setup_send/recv() was called before idmap_child_handle()

2020-10-23T03:25:36+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14539

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer

winbindd: add generic wb_parent_idmap_setup_send/recv() helpers

2020-10-23T03:25:36+00:00

This is more or less a copy of wb_xids2sids_init_dom_maps_send/recv,
but it's more generic and doesn't imply global state.

It also closes a initialization race by using a tevent_queue to
serialize the calls.

In the next commits we'll replace wb_xids2sids_init_dom_maps_send/recv.

We'll also use the new function in the wb_sids2xids code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14539

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer

winbindd: add and use is_idmap_child()

2020-10-23T03:25:35+00:00

We should avoid calling idmap_child() as much as possible.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14539

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Gary Lockyer