samba.git/source3/winbindd/winbindd_rpc.c, branch talloc-2.1.7

s3:winbindd: initialize dst->primary_gid with (gid_t)-1

2015-07-17T17:06:08+00:00

We should not leave this uninitialized.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 
Reviewed-by: Michael Adam 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Fri Jul 17 19:06:08 CEST 2015 on sn-devel-104

s3:winbindd: initialize acct_desc fields in rpc_enum_{dom,local}_groups()

2015-07-17T14:01:14+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 
Reviewed-by: Michael Adam

s3:winbindd: initialize an [in,out] variable in rpc_try_lookup_sids3()

2015-07-17T14:01:14+00:00

The input value of count is ignored by the server,
but we should not send an uninitialized value.

Found by valgrind.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 
Reviewed-by: Michael Adam

s3:winbindd: avoid invalid pointer type warnings

2014-11-25T06:25:45+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

winbindd: Do not segfault if the trusted domain has no SID

2014-08-31T22:36:42+00:00

Currently we abort, as skipping the domain would make the loop much more complex for a situation not yet seen in the real world.

Andrew Bartlett

Change-Id: Ie1e269eb25047d662d8fd0f771ee20de1d48706b
Signed-off-by: Andrew Bartlett 
Reviewed-by: Stefan Metzmacher 
Reviewed-By: Jelmer Vernooij

winbindd: Ensure we do not look at rid_array before checking if it was returned

2014-04-02T09:05:46+00:00

We no longer return early if there are no members, we just return an empty array.

Change-Id: I7b0949e0c0b9277426a8007514a8658615f6c709
Signed-off-by: Andrew Bartlett 
Reviewed-by: David Disseldorp

rpc: fix name-normalization in rpc_sid_to_name()

2014-02-25T08:17:07+00:00

Hand the *input* name as input into the normalize call,
not the (potentially uninitialized...) *output* name...

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10463

Change-Id: I4f3fc25882c22d96329e252d0a53bbe13d533472
Pair-Programmed-With: Gregor Beck 
Signed-off-by: Gregor Beck 
Signed-off-by: Michael Adam 
Reviewed-by: Stefan Metzmacher

rpc: correctly tread domain-only requests in rpc_sid_to_name()

2014-02-25T08:17:07+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10463

Change-Id: I6a8a8c272b9cf7dbce4f9a99012209c29c31e839
Pair-Programmed-With: Gregor Beck 
Signed-off-by: Gregor Beck 
Signed-off-by: Michael Adam 
Reviewed-by: Stefan Metzmacher

CVE-2013-4408:s3:Ensure LookupRids() replies arrays are range checked.

2013-12-09T08:00:41+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185

Signed-off-by: Jeremy Allison 
Signed-off-by: Stefan Metzmacher 

Autobuild-User(master): Karolin Seeger 
Autobuild-Date(master): Mon Dec  9 09:00:41 CET 2013 on sn-devel-104

CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.

2013-12-09T06:05:46+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185

Signed-off-by: Stefan Metzmacher 
Signed-off-by: Jeremy Allison