samba.git/source3/winbindd, branch talloc-2.2.0 Unnamed repository; edit this file 'description' to name the repository. winbindd: Use wrapper for string to integer conversion 2019-03-01T00:32:10+00:00 Swen Schillig swen@linux.ibm.com 2019-01-28T13:07:39+00:00 fdd529792639a60683df927a8e02d47d2749fd10 In order to detect an value overflow error during the string to integer conversion with strtoul/strtoull, the errno variable must be set to zero before the execution and checked after the conversion is performed. This is achieved by using the wrapper function strtoul_err and strtoull_err. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Ralph Böhme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
In order to detect an value overflow error during
the string to integer conversion with strtoul/strtoull,
the errno variable must be set to zero before the execution and
checked after the conversion is performed. This is achieved by
using the wrapper function strtoul_err and strtoull_err.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbind: Use idmap_cache_find_xid2sid 2019-02-28T12:57:24+00:00 Volker Lendecke vl@samba.org 2019-02-26T13:34:56+00:00 bc9824bd42d9370279819ea0d927e236f6041324 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
winbind: Now we explicitly track if we got ids from cache 2019-02-28T12:57:23+00:00 Volker Lendecke vl@samba.org 2019-02-25T13:55:00+00:00 95d33ca79cc315f1a2e41cd60859ef01d6548c77 This now properly makes us use negative cache entries Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813 
This now properly makes us use negative cache entries

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
winbind: Initialize "expired" parameter to idmap_cache_xid2sid 2019-02-28T12:57:23+00:00 Volker Lendecke vl@samba.org 2019-02-26T11:52:28+00:00 8c28c12702c0935a852c7fed6565987623f09fee The code in idmap_cache only touches its output parameters upon success Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813 
The code in idmap_cache only touches its output parameters upon success

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
idmap_cache: Only touch "sid" on success in find_xid_to_sid 2019-02-28T12:57:23+00:00 Volker Lendecke vl@samba.org 2019-02-26T11:46:39+00:00 4faf3e9f6da7515fc263d79f77226d105c2f8524 Why? This makes the negative mapping condition (is_null_sid) more explicit in the code. The callers in lookup_sid initialized "psid" anyway before, and the ones in wb_xids2sids now do as well. This is more in line with other APIs we have: Only touch output parameters if you have something to say. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813 
Why? This makes the negative mapping condition (is_null_sid) more
explicit in the code.

The callers in lookup_sid initialized "psid" anyway before, and the ones
in wb_xids2sids now do as well. This is more in line with other APIs we
have: Only touch output parameters if you have something to say.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
winbind: Avoid a "==False" 2019-02-27T00:35:19+00:00 Volker Lendecke vl@samba.org 2018-11-12T11:54:58+00:00 7d9b760418057c372f8e17739613a30e6b756823 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbind: Fix an error path memleak 2019-02-27T00:35:18+00:00 Volker Lendecke vl@samba.org 2018-10-15T06:32:33+00:00 e8efe16b3cb1bb6a5bae3b684deea63c8b4e8102 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbind: Align integer types 2019-02-27T00:35:18+00:00 Volker Lendecke vl@samba.org 2018-11-09T20:17:57+00:00 d48aa9a56b39f598a30ea29ef4b090cd48503cb8 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbindd: Fix typos 2019-02-27T00:35:18+00:00 Volker Lendecke vl@samba.org 2018-10-30T13:55:35+00:00 d83741091fad3cf343106900d328c09b12e18346 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
winbindd: set idmap cache entries as the last step in async wb_xids2sids 2019-02-23T08:23:21+00:00 Ralph Boehme slow@samba.org 2019-02-21T15:55:09+00:00 9b9565c3e69b92c298c7168e516387bb249c9e36 Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sat Feb 23 09:23:22 CET 2019 on sn-devel-144 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Feb 23 09:23:22 CET 2019 on sn-devel-144