samba.git/source3, branch talloc-2.4.0

smbd: Modernize DBG statements in smbXsrv_open_global_store()

2023-01-18T11:49:38+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

smbd: Make smbXsrv_open_global_id_to_key() a bit more type-safe

2023-01-18T11:49:38+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

smbd: Directly initialize key in smbXsrv_open_global_fetch_locked()

2023-01-18T11:49:38+00:00

Don't leave the key.dptr pointer uninitialized

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

smbd: Remove unused smbXsrv_open_global_key_to_id()

2023-01-18T11:49:38+00:00

This isn't exactly rocket science we would need to keep around

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

smbd: Slightly simplify smbXsrv_open_create()

2023-01-18T11:49:38+00:00

Move allocation of smbXsrv_open_global0 out of
smbXsrv_open_global_allocate()

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

smbd: Remove smbXsrv_open_global_destructor()

2023-01-18T11:49:38+00:00

This did not do much.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

smbd: Slightly simplify smb2srv_open_recreate()

2023-01-18T11:49:38+00:00

This moves the bit-fiddling right next to the check we do,
"global_zeros" was only used for this one purpose and its assignment
was a few lines away.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

s3/libsmb: fix a typo in parameter description

2023-01-17T17:21:38+00:00

Signed-off-by: Björn Baumbach 
Reviewed-by: Ralph Boehme

s3: smbd: Tweak openat_pathref_dirfsp_nosymlink() to NULL out fsp->fsp_name after calling fd_close() on intermediate directories, rather than before.

2023-01-13T08:33:47+00:00

vfs_virusfilter expects a non-NULL fsp->fsp_name to use for printing debugs
(it always indirects fsp->fsp_name). vfs_fruit also does the same, so would
also crash in fruit_close() with 'debug level = 10' and vfs_default:VFS_OPEN_HOW_RESOLVE_NO_SYMLINKS = no
set (we don't test with that which is why we haven't noticed
this before).

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15283

Signed-off-by: Jeremy Allison 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Jan 13 08:33:47 UTC 2023 on sn-devel-184

selftest: Show vfs_virusscanner crashes when traversing a 2-level directory tree.

2023-01-13T07:34:35+00:00

Modify check_infected_read() test to use a 2-level deep
directory.

We must have vfs_default:VFS_OPEN_HOW_RESOLVE_NO_SYMLINKS = no
set on the virusscanner share as otherwise the openat flag
shortcut defeats the test.

Add knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15283

Signed-off-by: Jeremy Allison 
Reviewed-by: Volker Lendecke