samba.git/source4/auth/gensec, branch talloc-2.3.1

s4:auth: use the correct client realm in gensec_gssapi_update_internal()

2019-09-24T18:30:37+00:00

The function gensec_gssapi_client_creds() may call kinit and gets
a TGT for the user. The principal provided by the user may not
be canonicalized. The user may use 'given.last@example.com'
but that may be mapped to glast@AD.EXAMPLE.PRIVATE in the background.

It means we should use client_realm = AD.EXAMPLE.PRIVATE
instead of client_realm = EXAMPLE.COM

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Guenther Deschner

s4/gensec/py: avoid null deref with bad python arguments

2019-07-22T22:20:26+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

s4/auth/pygensec: don't segfault when reporting bad types

2019-07-22T22:20:26+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

s4/auth/gensec: clang: Fix 'initialization value is never read'

2019-07-11T04:08:13+00:00

Fixes:

source4/auth/gensec/gensec_gssapi.c:431:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
        NTSTATUS nt_status = NT_STATUS_LOGON_FAILURE;
                 ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

py3: Remove PyStr_AsString() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

py3: Remove PyStr_FromString() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

s4: squash 'cast between incompatible function types' warning

2019-05-16T17:55:17+00:00

To avoid warning above produced by using
 -Wcast-function-type we;

  + ensure PyCFunctions of type METH_NOARGS defined dummy arg
  + ensure PyCFunctions of type METH_KEYWORDS use PY_DISCARD_FUNC_SIG
    macro
  + ensure PyCFunctions of type METH_KEYWORDS really actually use the
    problematic kargs param, if not remove it

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s4:auth: Fix debug statement in gensec_gssapi

2019-05-08T16:33:24+00:00

The 'role' is set to null, we should first set it to the correct value
before printing anything.

Found by GCC 9.

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

build: Remove bld.gen_python_environments()

2019-03-21T04:06:14+00:00

This was part of --extra-python support.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam

Fix mem leak with PyBytes_FromStringAndSize

2019-02-13T10:42:08+00:00

Reviewed-by: Andrew Bartlett abartlet@samba.org