samba.git/source4/auth, branch talloc-2.3.0

s4/auth/gensec: clang: Fix 'initialization value is never read'

2019-07-11T04:08:13+00:00

Fixes:

source4/auth/gensec/gensec_gssapi.c:431:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
        NTSTATUS nt_status = NT_STATUS_LOGON_FAILURE;
                 ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

py3: Remove duplicated PyUnicode_Check() after the py3 compat macros were removed

2019-06-24T18:48:53+00:00

This came about because in py2 we had to check for strings and unicode.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Mon Jun 24 18:48:53 UTC 2019 on sn-devel-184

py3: Remove PyStr_AsUTF8AndSize() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

py3: Remove PyStr_AsString() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

py3: Remove PyStr_FromString() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

py3: Remove PyStr_Check() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

auth auth_log: csbuild unused parm unix_username

2019-06-13T07:16:22+00:00

Fixes csbuild errors

Error: COMPILER_WARNING:
auth/auth_log.c: scope_hint: In function ‘log_authentication_event_json’
auth/auth_log.c:146:14: warning: unused parameter ‘unix_username’
[-Wunused-parameter]

Error: COMPILER_WARNING:
auth/auth_log.c: scope_hint: In function
‘log_authentication_event_human_readable’
auth/auth_log.c:586:14: warning: unused parameter ‘unix_username’
[-Wunused-parameter]

Signed-off-by: Gary Lockyer 
Reviewed-by: Andreas Schneider

Remove unused auth_get_challenge_not_implemented

2019-05-22T05:59:13+00:00

This became unused after eba87995145b0e14672c1f6993f7aa3422d62541 in 2012

Found by callcatcher

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

s4: squash 'cast between incompatible function types' warning

2019-05-16T17:55:17+00:00

To avoid warning above produced by using
 -Wcast-function-type we;

  + ensure PyCFunctions of type METH_NOARGS defined dummy arg
  + ensure PyCFunctions of type METH_KEYWORDS use PY_DISCARD_FUNC_SIG
    macro
  + ensure PyCFunctions of type METH_KEYWORDS really actually use the
    problematic kargs param, if not remove it

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s4/auth/sam: silence CID 1435849

2019-05-09T22:39:27+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer