samba.git/source4/dns_server, branch talloc-2.3.2

bind9-dlz: Add support for BIND 9.16.x

2020-09-24T04:32:41+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14487

Signed-off-by: Amitay Isaacs 
Reviewed-by: Rowland Penny

bind9-dlz: Add support for BIND 9.14.x

2020-09-24T04:32:41+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14487

Signed-off-by: Amitay Isaacs 
Reviewed-by: Rowland Penny

bind9-dlz: Bind 9.13.x switched to using bool as isc_boolean_t instead of int.

2020-09-24T04:32:41+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14487

Signed-off-by: Amitay Isaacs 
Reviewed-by: Rowland Penny

lib/util: remove extra safe_string.h file

2020-08-28T02:18:40+00:00

lib/util/safe_string.h is similar to source3/include/safe_string.h, but
the former has fewer checks. It is missing bcopy, strcasecmp, and
strncasecmp.

Add the missing elements to lib/util/safe_string.h remove the other
safe_string.h which is in the source3-specific path. To accomodate
existing uses of str(n?)casecmp, add #undef lines to source files where
they are used.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184

lib: relicense smb_strtoul(l) under LGPLv3

2020-08-03T22:21:02+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Swen Schillig 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Mon Aug  3 22:21:04 UTC 2020 on sn-devel-184

s4/rpc_server/dnsserver: Allow parsing of dnsProperty to fail gracefully

2020-05-15T07:29:16+00:00

On (eg) the

DC=_msdcs.X.Y,CN=MicrosoftDNS,DC=ForestDnsZones,DC=X,DC=Y

record, in domains that have had a Microsoft Windows DC an attribute:

dNSProperty:: AAAAAAAAAAAAAAAAAQAAAJIAAAAAAAAA

000000 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00  >................<
000010 92 00 00 00 00 00 00 00                          >........<
000018

We, until samba 4.12, would parse this as:

pull returned Success
    dnsp_DnsProperty: struct dnsp_DnsProperty
        wDataLength              : 0x00000000 (0)
        namelength               : 0x00000000 (0)
        flag                     : 0x00000000 (0)
        version                  : 0x00000001 (1)
        id                       : DSPROPERTY_ZONE_NS_SERVERS_DA (146)
        data                     : union dnsPropertyData(case 0)
        name                     : 0x00000000 (0)
dump OK

However, the wDataLength is 0.  There is not anything in
[MS-DNSP] 2.3.2.1 dnsProperty to describe any special behaviour
for when the id suggests that there is a value, but wDataLength is 0.

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dnsp/445c7843-e4a1-4222-8c0f-630c230a4c80

We now fail to parse it, because we expect an entry with id DSPROPERTY_ZONE_NS_SERVERS_DA
to therefore have a valid DNS_ADDR_ARRAY (section 2.2.3.2.3).

As context we changed it in our commit fee5c6a4247aeac71318186bbff7708d25de5912
because of bug https://bugzilla.samba.org/show_bug.cgi?id=14206
which was due to the artificial environment of the fuzzer.

Microsoft advises that Windows also fails to parse this, but
instead of failing the operation, the value is ignored.

Reported by Alex MacCuish.  Many thanks for your assistance in
tracking down the issue.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14310

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri May 15 07:29:17 UTC 2020 on sn-devel-184

Fix clang 9 missing-field-initializer warnings

2020-05-08T09:31:31+00:00

Signed-off-by: Gary Lockyer 
Reviewed-by: Andreas Schneider

dlz_bind9: Avoid talloc_new(NULL), use a parent variable

2020-04-01T08:51:31+00:00

This will help provide a better memory tree if we ever suspect a problem
here.  The tmp_ctx varaible is always freed before the end of this
function.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

dns: Always return SOA record for records we should know

2019-11-08T12:31:29+00:00

Regression introduced by commit 4b54e14b7cf456e327b176b365e8471e0899210b,
where the number of returned records is not set by talloc_array_length
when the record is not found.

Found by DELL EMC at SDC SMB3 plugfest trying to perform a secure DNS
update.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Samuel Cabrero 
Autobuild-Date(master): Fri Nov  8 12:31:30 UTC 2019 on sn-devel-184

s4: free popt context in dnsserver

2019-08-22T00:21:51+00:00

If done with popt context it should be free'd.

Signed-off-by: Swen Schillig 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Ralph Böhme