samba.git/source4/dsdb/tests/python/password_lockout.py, branch talloc-2.3.2

selftest: add test for new "samba-tool user unlock" command

2020-11-04T00:19:25+00:00

Signed-off-by: Björn Baumbach 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Wed Nov  4 00:19:25 UTC 2020 on sn-devel-184

pytests: heed assertEquals deprecation warning en-masse

2020-02-07T10:37:37+00:00

TestCase.assertEquals() is an alias for TestCase.assertEqual() and
has been deprecated since Python 2.7.

When we run our tests with in python developer mode (`PYTHONDEVMODE=1
make test`) we get 580 DeprecationWarnings about this.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

PY3: change shebang to python3 in source4/dsdb dir

2018-12-14T13:40:20+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Noel Power

s4/dsdb/tests/python: PY3 Port samba4.ldap.password_lockout

2018-12-10T09:38:23+00:00

use Exception.args member as exception is no longer supports
indexing.

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

PY3: net.change_password & net.set_password take string not bytes

2018-12-10T09:38:21+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

CVE-2018-16857 tests: Sanity-check password lockout works with default values

2018-11-28T07:22:25+00:00

Sanity-check that when we use the default lockOutObservationWindow that
user lockout actually works.

The easiest way to do this is to reuse the _test_login_lockout()
test-case, but stop at the point where we wait for the lockout duration
to expire (because we don't want the test to wait 30 mins).

This highlights a problem currently where the default values don't work.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13683

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

python: do not use "is" for string equality

2018-10-29T22:13:36+00:00

This is not always going to work, and is not guaranteed to be
consistent even between minor versions.

Here is a simple counterexample:

>>> a = 'hello'
>>> a is 'hello'
True
>>> a is 'hello'.lower()
False
>>> a == a.lower()
True

Possibly it always works for the empty string, but we cannot rely
on that.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Mon Oct 29 23:13:36 CET 2018 on sn-devel-144

selftest: Split up password_lockout into tests with and without a call to sleep()

2018-09-03T04:14:55+00:00

This means we can have a long observation window for many of the tests and
so make them much more reliable.  Many of these cause frustrating flapping
failures in our CI systems.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Sep  3 06:14:55 CEST 2018 on sn-devel-144

selftest: Prepare to allow override of lockout duration in password_lockout tests

2018-09-03T01:22:25+00:00

This will make it easier to avoid flapping tests.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

PEP8: improve formatting around bit-wise OR ("|")

2018-08-24T05:49:32+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett