samba.git/source4/dsdb/tests/python/sam.py, branch talloc-2.4.0

s4-dsdb: Use Python 'del' rather than assigning over with None

2022-10-21T03:57:33+00:00

This is the clearer way to trigger the destruction of this variable
and so the LDB connection under it.

Signed-off-by: Joseph Sutton 
Reviewed-by: Douglas Bagnall

s4-dsdb: remove unused Python variables

2022-10-21T03:57:33+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Douglas Bagnall

s4-dsdb: Use a raw python string to avoid creating and invalid escape sequence

2022-10-21T03:57:33+00:00

While the invalid escape sequence worked and was passed to the LDB
layer for it's use, linting tools will complain so we should not do
this.  We don't want to get caught out when a future python version
becomes more strict.

Signed-off-by: Joseph Sutton 
Reviewed-by: Douglas Bagnall

tests/sam: Ensure that Protected Users group cannot be deleted

2022-03-18T11:55:30+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Stefan Metzmacher

CVE-2020-25722 selftest: Add test for duplicate servicePrincipalNames on an add operation

2021-11-09T19:45:34+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14564

Signed-off-by: Joseph Sutton

CVE-2020-25722 selftest: adapt ldap.py/sam.py test_all tests to new default computer behaviour

2021-11-09T19:45:32+00:00

Objects of objectclass computer are computers by default now and this changes
the sAMAccountType and primaryGroupID as well as userAccountControl

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14753

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

CVE-2020-25722 selftest: Adapt sam.py test to userAccountControl/objectclass restrictions

2021-11-09T19:45:32+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14753

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

CVE-2020-25722 selftest: New objects of objectclass=computer are workstations by default now

2021-11-09T19:45:32+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14753

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

CVE-2020-25722 selftest: Adjust sam.py test_userAccountControl_computer_add_trust to new reality

2021-11-09T19:45:32+00:00

We now enforce that a trust account must be a user.

These can not be added over LDAP anyway, and our C
code in the RPC server gets this right in any case.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14753

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

CVE-2020-25722 selftest: Split test_userAccountControl into unit tests

2021-11-09T19:45:32+00:00

The parts that create and delete a single object can be
safely split out into an individual test.

At this point the parts that fail against Windows 2019 are:

error: __main__.SamTests.test_userAccountControl_computer_add_normal [
_ldb.LdbError: (53, 'LDAP error 53 LDAP_UNWILLING_TO_PERFORM -  <0000052D: SvcErr: DSID-031A1236, problem 5003 (WILL_NOT_PERFORM), data 0\n> <>')
error: __main__.SamTests.test_userAccountControl_computer_modify [
_ldb.LdbError: (53, 'LDAP error 53 LDAP_UNWILLING_TO_PERFORM -  <0000052D: SvcErr: DSID-031A1236, problem 5003 (WILL_NOT_PERFORM), data 0\n> <>')
error: __main__.SamTests.test_userAccountControl_user_add_0_uac [
_ldb.LdbError: (53, 'LDAP error 53 LDAP_UNWILLING_TO_PERFORM -  <0000052D: SvcErr: DSID-031A1236, problem 5003 (WILL_NOT_PERFORM), data 0\n> <>')
error: __main__.SamTests.test_userAccountControl_user_add_normal [
_ldb.LdbError: (53, 'LDAP error 53 LDAP_UNWILLING_TO_PERFORM -  <0000052D: SvcErr: DSID-031A1236, problem 5003 (WILL_NOT_PERFORM), data 0\n> <>')
error: __main__.SamTests.test_userAccountControl_user_modify [
_ldb.LdbError: (53, 'LDAP error 53 LDAP_UNWILLING_TO_PERFORM -  <0000052D: SvcErr: DSID-031A1236, problem 5003 (WILL_NOT_PERFORM), data 0\n> <>')

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14753

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall