samba.git/source4/dsdb/tests/python/sort.py, branch talloc-2.2.0

PY3: change shebang to python3 in source4/dsdb dir

2018-12-14T13:40:20+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Noel Power

s4/dsdb/tests/python: Restore embed NULL tests for Python3

2018-12-13T23:51:32+00:00

commit: 34ca15fb042e42773854c093ad9f1e67696c90ac changed the
test so embedded NULLs were avoided when python3 was used.
This was due to the fact the string comparison function
'locale.strcoll' cannot handle embedded NULLs. This commit

a) Restores the test data using embedded NULLs which was
   not used depending on the python runtime version
b) Removes the problematic calculation of expected sorting order
   and instead uses sort order data stored in files.

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

selftest: Convert samba4.ldap.sort.python to planoldpythontest

2018-12-13T23:51:32+00:00

Currently the test only runs fully under python2. As an interim
measure while we figure out how to get this to work property under
python3 I have converted the test to planoldpythontest so it also
can run under python2

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

s4/dsdb/tests/python: PY3 allow test samba4.ldap.sort pass

2018-12-10T09:38:24+00:00

Adjust test data to remove use of embedded NULLs.

We are getting the following exception when running the test
under python3

Exception: Exception: Traceback (most recent call last):
  File "source4/dsdb/tests/python/sort.py", line 181, in setUp
    key=cmp_to_key_fn(locale.strcoll))
ValueError: embedded null character

Looking at the source code for locale.strcoll the lhs & rhs
params are processed using 'PyUnicode_AsWideCharString(s, NULL)'

Documentation for PyUnicode_AsWideCharString states:

"Convert the Unicode object to a wide character string.
 The output string always ends with a null character. If size is
 not NULL, write the number of wide characters (excluding the
 trailing null termination character) into *size. Note that the
 resulting wchar_t string might contain null characters, which
 would cause the string to be truncated when used with most C
 functions. If size is NULL and the wchar_t* string contains null
 characters a ValueError is raised."

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

s4/dsdb/tests/python: partial PY3 port for samba4.ldap.sort

2018-12-10T09:38:24+00:00

Test still fails after applying the following fixes

a) only decode byte or (py2) str objects
b) fix sorted function no longer use cmp func, use compat
   cmp_to_key_fn instead
c) convert ldb.bytes returned from ldb search results
d) convert sort_functions.keys() to list so array slicing works

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

s4/dsdb/pytest/sort: use compat.cmp_fn instead of cmp

2018-10-25T19:45:58+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

PEP8: fix E127: continuation line over-indented for visual indent

2018-09-06T10:10:12+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

PEP8: fix E305: expected 2 blank lines after class or function definition, found 1

2018-08-24T05:49:30+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E301: expected 1 blank line, found 0

2018-08-24T05:49:29+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E226: missing whitespace around arithmetic operator

2018-08-24T05:49:28+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall