samba.git/source4/dsdb, branch talloc-2.4.4 Unnamed repository; edit this file 'description' to name the repository. dsdb: Align an integer type 2025-08-31T07:23:20+00:00 Volker Lendecke vl@samba.org 2025-08-30T12:04:11+00:00 e5ba8cb6e97607a60db91c43f553b8bafa388394 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sun Aug 31 07:23:20 UTC 2025 on atb-devel-224 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun Aug 31 07:23:20 UTC 2025 on atb-devel-224
dsdb: Fix CID 1665142, Null pointer dereferences (FORWARD_NULL) 2025-08-31T06:22:37+00:00 Volker Lendecke vl@samba.org 2025-08-30T12:01:59+00:00 dede5475d3da31af89394c71b3ade706da7358a9 Do the ADD/MOD early, don't risk dereferencing msg without assignment. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> 
Do the ADD/MOD early, don't risk dereferencing msg without assignment.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
s4:dsdb:tests: Add tests for msDS-KeyCredentialLink attribute 2025-08-27T04:44:59+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-08-20T07:10:43+00:00 50edad8249c7c1063b0e38f02c2ea5a53e9d430d Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org> Autobuild-Date(master): Wed Aug 27 04:44:59 UTC 2025 on atb-devel-224 
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Aug 27 04:44:59 UTC 2025 on atb-devel-224
s4:dsdb: Implement msDS-KeyCredentialLink attribute 2025-08-27T03:41:36+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-06-05T00:28:20+00:00 a9c6e1ac37065d0b7a4c459c3b2933321ec074c3 Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
s4:dsdb:tests: Add get_creds() method 2025-08-27T03:41:36+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-08-12T23:41:53+00:00 cd39c04fd9279d84aa3861e8e0f70409e4c3fc99 Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
s4:dsdb: Remove outdated comments 2025-08-27T03:41:36+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-08-12T21:54:00+00:00 b5cee3b2dbdf20cefe71461b921a13d4ed37113b Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
s4:dsdb:tests: Remove outdated comment 2025-08-27T03:41:36+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-08-12T05:19:55+00:00 d41d350ce7f54d688c2c154fe86e073f77736c42 The relevant tests were enabled in commit 8cb416a0b569017e1928a7a1cead723ce64ca314. Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
The relevant tests were enabled in commit 8cb416a0b569017e1928a7a1cead723ce64ca314.

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
s4:dsdb:acl: Fix LDB flags comparison 2025-08-27T03:41:36+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-08-12T01:56:16+00:00 468563484963216e632ea0f8cbc71aede837215e LDB_FLAG_MOD_* values are not actually flags, and the previous comparison was equivalent to (el->flags & LDB_FLAG_MOD_MASK) == 0 which is only true if none of the LDB_FLAG_MOD_* values are set, so we would not successfully return if the element was a DELETE. Correct the expression to what it was intended to be. Commit 99b805e4cbeec232c65adb1a6f3fb326b55c4496 fixed a similar issue. Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
LDB_FLAG_MOD_* values are not actually flags, and the previous
comparison was equivalent to

(el->flags & LDB_FLAG_MOD_MASK) == 0

which is only true if none of the LDB_FLAG_MOD_* values are set, so we
would not successfully return if the element was a DELETE. Correct the
expression to what it was intended to be.

Commit 99b805e4cbeec232c65adb1a6f3fb326b55c4496 fixed a similar issue.

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
s4:dsdb: Allow an SPN value to match the original dNSHostName with Validated Write 2025-08-27T03:41:36+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-07-29T03:59:09+00:00 3f9f2c9efccdfc092869643ceffc2bb050858eb6 Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
s4:dsdb:tests: Correct unprefixed f‐string 2025-08-27T03:41:36+00:00 Jennifer Sutton jennifersutton@catalyst.net.nz 2025-07-29T03:02:32+00:00 0615268a1c0149d5acee9138873c1ed641637e0d Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>