samba.git/source4/kdc, branch talloc-2.4.2

s4:kdc: Remove unused includes

2023-12-08T02:28:33+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:kdc: Don’t convey PAC buffers from an RODC‐issued PAC

2023-11-07T22:54:42+00:00

Such buffers are not to be trusted.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Nov  7 22:54:42 UTC 2023 on atb-devel-224

s4:kdc: Move return code checks closer to where the return codes are set

2023-11-07T21:54:32+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:kdc: Call kdc_request_set_e_data() instead of kdc_set_e_data()

2023-11-01T20:10:45+00:00

NOTE: This commit finally works again!

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:kdc: Have samba_kdc_get_device_info_blob() call samba_kdc_get_user_info_dc() instead of adding special SIDs itself

2023-11-01T20:10:45+00:00

samba_kdc_get_user_info_dc() will add the Asserted Identity and Claims
Valid SIDs as appropriate.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:kdc: Do not add Claims Valid SID twice

2023-11-01T20:10:45+00:00

samba_kdc_get_user_info_dc() now adds the SID itself.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:kdc: Add the Asserted Identity SID to the PAC only if the original RODC‐issued PAC contained it

2023-11-01T20:10:45+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:kdc: Add Claims Valid SID to info regenerated from RODC‐issued PACs

2023-11-01T20:10:45+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:kdc: Simplify principal_comp_strcmp_int() to handle only equality

2023-10-26T02:26:02+00:00

We only ever use the principal comparison functions to check equality.
Having these functions only handle equality simplifies their
implementation and makes them a bit easier to use.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15482

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Oct 26 02:26:02 UTC 2023 on atb-devel-224

s4:kdc: Check for overflow before calling smb_krb5_princ_component()

2023-10-26T01:24:32+00:00

smb_krb5_princ_component() takes its component index parameter as ‘int’,
not ‘unsigned int’.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15482

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett